Grub Development Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [BUGFIX] Fix rescue parser
Date: Fri, 16 Oct 2009 20:34:44 +0200	[thread overview]
Message-ID: <20091016183444.GC7037@thorin> (raw)
In-Reply-To: <4AD71E62.1010102@gmail.com>

On Thu, Oct 15, 2009 at 03:06:42PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> 
> -- 
> Regards
> Vladimir 'phcoder' Serbinenko
> Personal git repository: http://repo.or.cz/w/grub2/phcoder.git 
> 

> diff --git a/ChangeLog b/ChangeLog
> index b0864a9..55bdc92 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,11 @@
>  2009-10-15  Vladimir Serbinenko  <phcoder@gmail.com>
>  
> +	* kern/parser.c (grub_parser_split_cmdline): Fix incorrect counting
> +	of arguments. Return number of tokens and not arguments. All users
> +	updated.
> +

Sorry, this change is too scary for 1.97.  I'd rather release with a known
minor bug than with potential for major one.

After 1.97 is released, feel free to commit this.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



      reply	other threads:[~2009-10-16 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 13:06 [BUGFIX] Fix rescue parser Vladimir 'phcoder' Serbinenko
2009-10-16 18:34 ` Robert Millan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091016183444.GC7037@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox