From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Subject: Re: Migrations to xorriso
Date: Thu, 20 May 2010 11:30:33 +0200 [thread overview]
Message-ID: <20100520093033.88110@gmx.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1554 bytes --]
Hi,
attached is an updated patch to summarize my
current proposal for grub-mkrescue.
My reply to mails of Vladimir and Seth seems
still stuck in eggs.gnu.org. (At least that
was the culprit last time.)
The current proposal follows Vladimir's idea:
> I'm thinking to allow passing arbitrary options to xorriso by just
> putting it on command line.
It would give the user control over option
-no-pad (saves 300 kB) and allow to switch from
mkisofs emulation to the native xorriso command
set.
-----------------------------------------------
New ponderings:
-----------------------------------------------
The following statement in the proposed help text
is due to the way how extra arguments are handled
via variable $source:
"Be aware that source paths must be single words.
Quotation marks will not work."
If grub-mkrescue options would be prescribed to
precede any source paths or xorriso options, then
we could use a while loop, shift and "$@",
rather than a for loop and ${source}.
while test -n "$1"; do
case "$1" in
...
--modules=*)
modules=`echo "$1" | sed 's/--modules=//'`
shift
;;
...
*)
break ;;
esac
done
...
${xorriso} ... "$@"
This would be safe for nearly all filenames.
(Newlines are still not allowed then.)
Question is whether support for apple-ish file
names is worth a change in the rules for
grub-mkrescue.
Have a nice day :)
Thomas
--
GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT!
Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01
[-- Attachment #2: grub-mkrescue.in.ts2.patch --]
[-- Type: text/x-patch, Size: 1923 bytes --]
--- grub-mkrescue.in 2010-05-18 10:02:06.000000000 +0200
+++ grub-mkrescue.in.ts2 2010-05-20 09:34:56.000000000 +0200
@@ -38,6 +38,8 @@ efi32_dir=${libdir}/$(echo ${PACKAGE_TAR
efi64_dir=${libdir}/$(echo ${PACKAGE_TARNAME} | sed ${transform})/x86_64-efi
rom_directory=
+xorriso=xorriso
+
# Usage: usage
# Print the usage.
usage () {
@@ -50,10 +52,15 @@ Make GRUB rescue image.
--output=FILE save output in FILE [required]
--modules=MODULES pre-load specified modules MODULES
--rom-directory=DIR save rom images in DIR [optional]
+ --xorriso=PROGFILE use PROGFILE as xorriso program [optional]
-$0 generates a bootable rescue image with specified source files or directories.
+$0 generates a bootable rescue image with specified source files, source
+directories, or mkisofs options listed by: xorriso -as mkisofs -help
+Option -- switches to native xorriso command mode.
+Be aware that source paths must be single words. Quotation marks will not work.
Report bugs to <bug-grub@gnu.org>.
+Mail xorriso support requests to <bug-xorriso@gnu.org>.
EOF
}
@@ -78,11 +85,8 @@ for option in "$@"; do
PATH=${override_dir}:$PATH
export PATH
;;
- -*)
- echo "Unrecognized option \`$option'" 1>&2
- usage
- exit 1
- ;;
+ --xorriso=*)
+ xorriso=`echo "${option}/" | sed 's/--xorriso=//'` ;;
*)
source="${source} ${option}" ;;
esac
@@ -254,7 +258,12 @@ if [ -e "${iso9660_dir}/boot/coreboot.el
fi
# build iso image
-xorriso -pathspecs on -as mkisofs ${grub_mkisofs_arguments} --protective-msdos-label -o ${output_image} -r ${iso9660_dir} ${source}
+"${xorriso}" -report_about HINT -as mkisofs -graft-points \
+ ${grub_mkisofs_arguments} --protective-msdos-label -r \
+ --sort-weight 0 / --sort-weight 1 /boot \
+ -o "${output_image}" \
+ ${iso9660_dir} ${source}
+
rm -rf ${iso9660_dir}
rm -f ${embed_img}
next reply other threads:[~2010-05-20 9:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 9:30 Thomas Schmitt [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-19 12:01 Migrations to xorriso Thomas Schmitt
2010-05-19 12:13 ` Colin Watson
2010-05-19 13:23 ` Thomas Schmitt
2010-05-19 21:02 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-19 18:40 ` Isaac Dupree
2010-05-19 19:34 ` Thomas Schmitt
2010-05-19 21:10 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-19 21:35 ` Seth Goldberg
2010-05-19 21:00 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-17 21:33 Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-18 8:49 ` Thomas Schmitt
2010-05-18 12:50 ` Thomas Schmitt
2010-05-19 19:45 ` Thomas Schmitt
2010-05-19 21:23 ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-05-20 6:31 ` Thomas Schmitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520093033.88110@gmx.net \
--to=scdbackup@gmx.net \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox