From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PKved-00007n-JK for mharc-grub-devel@gnu.org; Tue, 23 Nov 2010 11:23:39 -0500 Received: from [140.186.70.92] (port=37168 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PKvdU-0005Bs-1J for grub-devel@gnu.org; Tue, 23 Nov 2010 11:23:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PKvcO-0005zL-0H for grub-devel@gnu.org; Tue, 23 Nov 2010 11:22:27 -0500 Received: from smarthost02.mail.zen.net.uk ([212.23.3.141]:60940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PKvcN-0005z6-N5 for grub-devel@gnu.org; Tue, 23 Nov 2010 11:21:19 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost02.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1PKvcL-00014G-JF for grub-devel@gnu.org; Tue, 23 Nov 2010 16:21:17 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1PKvcJ-000545-00; Tue, 23 Nov 2010 16:21:15 +0000 Date: Tue, 23 Nov 2010 16:21:14 +0000 From: Colin Watson To: grub-devel@gnu.org Message-ID: <20101123162113.GG21862@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost02-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: powerpc/emu build failure X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2010 16:23:39 -0000 This is what I get for not building new snapshots for over three months: I get to spend a couple of solid days fixing build failures. :-) This time the failure's in the emu build on powerpc (https://buildd.debian.org/fetch.cgi?pkg=3Dgrub2&arch=3Dpowerpc&ver=3D1.99~= 20101123-1&stamp=3D1290514876&file=3Dlog&as=3Draw): gcc-4.4 -Os -Wall -W -Wshadow -Wpointer-arith -Wmissing-prototypes -Wunde= f -Wstrict-prototypes -g -fno-dwarf2-cfi-asm -m32 -fno-stack-protector -Wer= ror -DUSE_ASCII_FAILBACK=3D1 -DHAVE_UNIFONT_WIDTHSPEC=3D1 -m32 -Wl= ,--build-id=3Dnone -o grub-emu kern/emu/grub_emu-full.o grub_emu-grub_em= u_init.o kernel.img trig.module = regexp.module = blocklist.module boot.module cat.module = cmp.module configfile.module date.module = echo.module extcmd.module gptsync.module = halt.module hashsum.module help.module = hexdump.module keystatus.module loadenv.module = ls.module lsmmap.module memrw.module = minicmd.module parttool.module password.module = password_pbkdf2.module probe.module re= ad.module reboot.module search.module search_= fs_file.module search_fs_uuid.module search_label.modul= e sleep.module terminal.module test.= module true.module videoinfo.module = videotest.module xnu_uuid.module dm_nv.module = loopback.module lvm.module mdraid09.module m= draid1x.module raid.module raid5rec.module ra= id6rec.module scsi.module memdisk.module = font.module affs.module afs.= module afs_be.module befs.module befs_be.modu= le btrfs.module cpio.module ext2.module = fat.module fshelp.module hfs.module hfsp= lus.module iso9660.module jfs.module minix.mo= dule minix2.module nilfs2.module ntfs.module = ntfscomp.module reiserfs.module sfs.module = tar.module udf.module ufs1.module ufs= 2.module xfs.module gettext.module gfxmenu.m= odule hello.module gzio.module bufio.module = elf.module crypto.module pbkdf2.module = setjmp.module = normal.module part_acorn.module = part_amiga.module part_apple.module part_gpt.modu= le part_msdos.module part_sun.module part_bsd= =2Emodule part_sunpc.module msdospart.module = gfxterm.module terminfo.module = functional_test.module example_functional_test.module= bitmap.module bitmap_scale.module jpeg.mod= ule png.module tga.module video_fb.module = video.module sdl.module datehook.module legacyc= fg.module test_blockarg.module xzio.module testload.mo= dule keylayouts.module gcry_arcfour.module gc= ry_twofish.module gcry_tiger.module gcry_whirlpool.modu= le gcry_md5.module gcry_rfc2268.module gcry_s= ha512.module gcry_rmd160.module gcry_crc.module = gcry_cast5.module gcry_camellia.module gcry_serpent.= module gcry_md4.module gcry_seed.module gcry_= blowfish.module gcry_sha256.module gcry_rijndael.module= gcry_des.module gcry_sha1.module zfs.module= zfsinfo.module -lncurses -lSDL -ldevmapper =20 kernel.img: In function `grub_dl_flush_cache': /build/buildd-grub2_1.99~20101123-1-powerpc-mAsrpj/grub2-1.99~20101123/bu= ild/grub-emu/grub-core/../../../grub-core/kern/dl.c:484: undefined referenc= e to `grub_arch_sync_caches' collect2: ld returned 1 exit status make[5]: *** [grub-emu] Error 1 It seems to me that we should probably include the emu implementation of grub_arch_sync_caches in the kernel when building for the emu platform. Does this patch look sane? 2010-11-23 Colin Watson * grub-core/Makefile.core.def (kernel): Add kern/emu/cache.S for emu platforms. (grub-emu-lite): Remove kern/emu/cache.S. =3D=3D=3D modified file 'grub-core/Makefile.core.def' --- grub-core/Makefile.core.def 2010-11-14 22:36:20 +0000 +++ grub-core/Makefile.core.def 2010-11-23 15:59:05 +0000 @@ -162,6 +162,7 @@ kernel =3D { emu =3D disk/host.c; emu =3D gnulib/progname.c; emu =3D gnulib/error.c; + emu =3D kern/emu/cache.S; emu =3D kern/emu/console.c; emu =3D kern/emu/getroot.c; emu =3D kern/emu/hostdisk.c; @@ -208,7 +209,6 @@ program =3D { name =3D grub-emu-lite; =20 emu =3D kern/emu/lite.c; - emu =3D kern/emu/cache.S; emu_nodist =3D symlist.c; =20 ldadd =3D 'kernel.img$(EXEEXT)'; --=20 Colin Watson [cjwatson@ubuntu.com]