From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PLG2L-00057S-3b for mharc-grub-devel@gnu.org; Wed, 24 Nov 2010 09:09:29 -0500 Received: from [140.186.70.92] (port=59768 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PLG2I-00056V-PR for grub-devel@gnu.org; Wed, 24 Nov 2010 09:09:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PLG2H-0002Mf-6G for grub-devel@gnu.org; Wed, 24 Nov 2010 09:09:26 -0500 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:39459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PLG2G-0002MH-W7 for grub-devel@gnu.org; Wed, 24 Nov 2010 09:09:25 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1PLG2F-0006uF-Do for grub-devel@gnu.org; Wed, 24 Nov 2010 14:09:23 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1PLG2C-0003bn-00; Wed, 24 Nov 2010 14:09:20 +0000 Date: Wed, 24 Nov 2010 14:09:20 +0000 From: Colin Watson To: The development of GNU GRUB Message-ID: <20101124140919.GL21862@riva.ucam.org> References: <20101123162113.GG21862@riva.ucam.org> <20101124120849.GA10958@riva.ucam.org> <4CED154E.2020800@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4CED154E.2020800@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: powerpc/emu build failure X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2010 14:09:27 -0000 On Wed, Nov 24, 2010 at 02:38:22PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 11/24/2010 01:08 PM, Colin Watson wrote: > > On Tue, Nov 23, 2010 at 04:21:14PM +0000, Colin Watson wrote: > >> It seems to me that we should probably include the emu implementation of > >> grub_arch_sync_caches in the kernel when building for the emu platform. > >> Does this patch look sane? > >> > >> 2010-11-23 Colin Watson > >> > >> * grub-core/Makefile.core.def (kernel): Add kern/emu/cache.S for emu > >> platforms. > >> (grub-emu-lite): Remove kern/emu/cache.S. > > > > I went ahead and committed this; Manoel Rebelo Abranches seemed keen on > > IRC, and it certainly doesn't break anything on x86 since the object is > > essentially empty there. > > Could you try the attached patch as a replacement for yours? Not that > your patch doesn't solve the problem but it's more annoying for maintenance. I think you meant to reply to http://lists.gnu.org/archive/html/grub-devel/2010-11/msg00053.html rather than to this thread. Anyway, this looks fine and compiles fine, although I haven't tried booting it. One thing, though: > +#define grub_swap_bytes16_compile_time(x) ((((x) & 0xff) << 8) | (((x) & 0xff00) >> 8)) > +#define grub_swap_bytes32_compile_time(x) ((((x) & 0xff) << 24) | (((x) & 0xff00) << 8) | (((x) & 0xff0000) >> 8) | (((x) & 0xff000000) >> 24)) Should the last one perhaps be 0xff000000UL, as in the grub_swap_bytes32 implementation? I forget the exact rules here but it would at least seem reasonable for the code to match as closely as possible for ease of maintenance. Thanks, -- Colin Watson [cjwatson@ubuntu.com]