From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1POuL9-0004Z6-GP for mharc-grub-devel@gnu.org; Sat, 04 Dec 2010 10:47:59 -0500 Received: from [140.186.70.92] (port=52108 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POuL7-0004Wp-JZ for grub-devel@gnu.org; Sat, 04 Dec 2010 10:47:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POuL6-0003Px-61 for grub-devel@gnu.org; Sat, 04 Dec 2010 10:47:57 -0500 Received: from smarthost01.mail.zen.net.uk ([212.23.3.140]:48503) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POuL5-0003PU-T8 for grub-devel@gnu.org; Sat, 04 Dec 2010 10:47:56 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost01.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1POuL4-000529-0Y for grub-devel@gnu.org; Sat, 04 Dec 2010 15:47:54 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1POuL3-0003fk-00; Sat, 04 Dec 2010 15:47:53 +0000 Date: Sat, 4 Dec 2010 15:47:53 +0000 From: Colin Watson To: The development of GNU GRUB Message-ID: <20101204154752.GA21862@riva.ucam.org> References: <4CF66EFE.4030400@gmail.com> <4CF7B02F.1020105@gmail.com> <20101202212920.GX21862@riva.ucam.org> <4CF812B2.8080209@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4CF812B2.8080209@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost01-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: Need --divide flag for assembly of startup.S on some platforms X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Dec 2010 15:47:58 -0000 On Thu, Dec 02, 2010 at 10:42:10PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 12/02/2010 10:29 PM, Colin Watson wrote: > > On Thu, Dec 02, 2010 at 01:15:10PM -0800, Seth Goldberg wrote: > >> Since the default for gas on these platforms is to use he division > >> operator as a comment delimiter, the "-Wa,--divide" flags need to be > >> passed on the gcc command line when assembling such files. > > > > Can we just use >> 1 instead? > > This was my first thought. But for maintenance reasons it would be > better if we can make all platforms behave the same. Can we just > inconditionally add -Wa,--divide to TARGET_ASFLAGS ? (Only on i386, since the existence of the --divide option is machine-dependent.) It'd be a substantial bump in our binutils requirement. Right now, INSTALL says that we require GNU binutils 2.9.1.0.23 or later. As far as I can make out from http://sourceware.org/cgi-bin/cvsweb.cgi/src/gas/config/tc-i386.c?cvsroot=src, --divide was added in binutils 2.17. Before that, if I'm reading the diff correctly, "/" unconditionally introduced a comment on certain platforms. So, is it better to require binutils 2.17, or to accept the maintenance burden of avoiding the / operator in i386 assembly? My instinct remains the latter, I think - I have no idea what version of binutils is in place on our various supported platforms, and I'm not even sure how to go about finding out, so raising it is a bit scary for me. I'm used to platforms that stay pretty current on the GNU toolchain, but I know not all platforms are like that. -- Colin Watson [cjwatson@ubuntu.com]