From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Re: ACPI halt failures in tests
Date: Thu, 23 Dec 2010 11:51:36 +0000 [thread overview]
Message-ID: <20101223115136.GW21862@riva.ucam.org> (raw)
In-Reply-To: <AANLkTinLORsN9-uDi-j8JOH5eJB-rFDotGLEQL3NRka4@mail.gmail.com>
On Thu, Dec 23, 2010 at 01:07:15AM -0800, Jordan Uggla wrote:
> I think it's more likely a race condition of sorts; it's assumed that
> the code that prints "ACPI shutdown failed" is unreachable when ACPI
> shutdown succeeds, since the code comes after shutdown has been
> requested. Part of the reason I think this is that the symptom I've
> been seeing is just "A" or "AC" being printed, which means that the
> shutdown is not synchronous (it's happening in the middle of a
> printf). Since in real hardware I can't see this being much of a
> problem (except maybe causing false alarms for people who log serial
> output), and it would be good to have some type of message on the
> screen when ACPI shutdown does fail, I don't think this should be just
> a dprintf. Instead I think that the unit test's grub.cfg should
> disable serial terminal just before running halt as a work around.
Thanks! This does indeed make more sense than my patch. I've gone
ahead and committed it, with trivial tweaks (including fixing the
spelling of your name in ChangeLog ;-) ).
--
Colin Watson [cjwatson@ubuntu.com]
prev parent reply other threads:[~2010-12-23 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 15:29 ACPI halt failures in tests Colin Watson
2010-12-23 9:07 ` [PATCH] " Jordan Uggla
2010-12-23 11:51 ` Colin Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223115136.GW21862@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).