From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1PVjhy-0001Ec-F2 for mharc-grub-devel@gnu.org; Thu, 23 Dec 2010 06:51:46 -0500 Received: from [140.186.70.92] (port=51271 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PVjhv-0001A1-Ka for grub-devel@gnu.org; Thu, 23 Dec 2010 06:51:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PVjhu-0004c2-FS for grub-devel@gnu.org; Thu, 23 Dec 2010 06:51:43 -0500 Received: from smarthost01.mail.zen.net.uk ([212.23.3.140]:57939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PVjhu-0004bW-Av for grub-devel@gnu.org; Thu, 23 Dec 2010 06:51:42 -0500 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost01.mail.zen.net.uk with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1PVjhr-0007s1-Vs for grub-devel@gnu.org; Thu, 23 Dec 2010 11:51:40 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 4.69) (envelope-from ) id 1PVjhp-0006U8-QP for grub-devel@gnu.org; Thu, 23 Dec 2010 11:51:37 +0000 Date: Thu, 23 Dec 2010 11:51:36 +0000 From: Colin Watson To: The development of GNU GRUB Message-ID: <20101223115136.GW21862@riva.ucam.org> References: <20101123152936.GF21862@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost01-IP: [82.69.40.219] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Re: ACPI halt failures in tests X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Dec 2010 11:51:44 -0000 On Thu, Dec 23, 2010 at 01:07:15AM -0800, Jordan Uggla wrote: > I think it's more likely a race condition of sorts; it's assumed that > the code that prints "ACPI shutdown failed" is unreachable when ACPI > shutdown succeeds, since the code comes after shutdown has been > requested. Part of the reason I think this is that the symptom I've > been seeing is just "A" or "AC" being printed, which means that the > shutdown is not synchronous (it's happening in the middle of a > printf). Since in real hardware I can't see this being much of a > problem (except maybe causing false alarms for people who log serial > output), and it would be good to have some type of message on the > screen when ACPI shutdown does fail, I don't think this should be just > a dprintf. Instead I think that the unit test's grub.cfg should > disable serial terminal just before running halt as a work around. Thanks! This does indeed make more sense than my patch. I've gone ahead and committed it, with trivial tweaks (including fixing the spelling of your name in ChangeLog ;-) ). -- Colin Watson [cjwatson@ubuntu.com]