From: Andrey Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug
Date: Sat, 20 Jul 2013 17:47:57 +0400 [thread overview]
Message-ID: <20130720174758.285fa56e@opensuse.site> (raw)
In-Reply-To: <1673590.C5H8tbIV1b@icedphoenix>
В Mon, 15 Jul 2013 17:35:15 +0400
Vladimir Testov <vladimir.testov@rosalab.ru> пишет:
> diff -Naur grub-new3/grub-core/gfxmenu/gui_list.c grub-new4/grub-core/gfxmenu/gui_list.c
> --- grub-new3/grub-core/gfxmenu/gui_list.c 2013-07-15 15:30:26.585116409 +0400
> +++ grub-new4/grub-core/gfxmenu/gui_list.c 2013-07-15 16:36:34.544169956 +0400
> @@ -273,16 +273,30 @@
> cwidth -= selbox->get_border_width (selbox);
> selbox->set_content_size (selbox, cwidth, item_height);
>
> - int string_left_offset = self->icon_width + icon_text_space;
> - int string_top_offset = (item_height - (ascent + descent)) / 2 + ascent;
> + int item_left_offset = self->icon_width + icon_text_space;
> + int item_top_offset = (item_height - (ascent + descent)) / 2 + ascent;
[...]
>
> grub_video_rect_t svpsave, sviewport;
> - sviewport.x = sel_leftpad + string_left_offset;
> - sviewport.width = cwidth - string_left_offset;
> + sviewport.x = sel_leftpad + item_left_offset;
> + sviewport.width = cwidth - item_left_offset;
> sviewport.height = item_height;
Is there any reason for renaming? Such changes usually obfuscate main
patch content and better done as separate patch with clear explanation.
next prev parent reply other threads:[~2013-07-20 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 13:35 [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug Vladimir Testov
2013-07-16 8:02 ` Vladimir Testov
2013-07-20 13:47 ` Andrey Borzenkov [this message]
2013-07-22 7:47 ` Vladimir Testov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130720174758.285fa56e@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).