From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V0XVz-00088E-O6 for mharc-grub-devel@gnu.org; Sat, 20 Jul 2013 09:48:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0XVx-000880-S6 for grub-devel@gnu.org; Sat, 20 Jul 2013 09:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0XVw-0007HF-SF for grub-devel@gnu.org; Sat, 20 Jul 2013 09:48:01 -0400 Received: from mail-la0-x230.google.com ([2a00:1450:4010:c03::230]:33291) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0XVw-0007HB-L1 for grub-devel@gnu.org; Sat, 20 Jul 2013 09:48:00 -0400 Received: by mail-la0-f48.google.com with SMTP id lx15so4035269lab.21 for ; Sat, 20 Jul 2013 06:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; bh=z1zyTibLw7Q5Sc2YBge5OolMxPU4CVS8R37TxWrA5UY=; b=j1IHMGJuRnxKRRzwvSas18c7jRPcatGtOpXvvB5yIh5IikUSxZQTLIwpK0v0dEv7Im zHME1wKzOnOAdBg2OQ/GdclSKbrFC1/1SJPBzRQZ2TJSV6rnpZfYzNusaBHjTXgCfP7R 9FuM+Mpmsf45i4L8J+WQjwaQ+fMC9Po/LI0MmE1pnf8ZvdK/1y/X7nzkU+/AdLJwPMvu ktHfRcPpYbWoIkNYux0DUop0ypvIioR/MVJocTnTH25yik40tS804KGgPqIj+zF9kz19 z1IU4T/5nRfAfNe7/9HLnslmw0N45570+YGhm1hgRtB7Odq4CmVK0NBH9dNguf9bKY1M mq2Q== X-Received: by 10.112.5.199 with SMTP id u7mr9290642lbu.67.1374328079434; Sat, 20 Jul 2013 06:47:59 -0700 (PDT) Received: from opensuse.site (ppp79-139-160-84.pppoe.spdop.ru. [79.139.160.84]) by mx.google.com with ESMTPSA id m1sm7733794lag.3.2013.07.20.06.47.58 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 20 Jul 2013 06:47:59 -0700 (PDT) Date: Sat, 20 Jul 2013 17:47:57 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: [PATCH] [4/?] grub-core/gfxmenu/gui_list.c - baseline centering bug Message-ID: <20130720174758.285fa56e@opensuse.site> In-Reply-To: <1673590.C5H8tbIV1b@icedphoenix> References: <1673590.C5H8tbIV1b@icedphoenix> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::230 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2013 13:48:03 -0000 В Mon, 15 Jul 2013 17:35:15 +0400 Vladimir Testov пишет: > diff -Naur grub-new3/grub-core/gfxmenu/gui_list.c grub-new4/grub-core/gfxmenu/gui_list.c > --- grub-new3/grub-core/gfxmenu/gui_list.c 2013-07-15 15:30:26.585116409 +0400 > +++ grub-new4/grub-core/gfxmenu/gui_list.c 2013-07-15 16:36:34.544169956 +0400 > @@ -273,16 +273,30 @@ > cwidth -= selbox->get_border_width (selbox); > selbox->set_content_size (selbox, cwidth, item_height); > > - int string_left_offset = self->icon_width + icon_text_space; > - int string_top_offset = (item_height - (ascent + descent)) / 2 + ascent; > + int item_left_offset = self->icon_width + icon_text_space; > + int item_top_offset = (item_height - (ascent + descent)) / 2 + ascent; [...] > > grub_video_rect_t svpsave, sviewport; > - sviewport.x = sel_leftpad + string_left_offset; > - sviewport.width = cwidth - string_left_offset; > + sviewport.x = sel_leftpad + item_left_offset; > + sviewport.width = cwidth - item_left_offset; > sviewport.height = item_height; Is there any reason for renaming? Such changes usually obfuscate main patch content and better done as separate patch with clear explanation.