From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice
Date: Sat, 20 Jul 2013 18:18:04 +0400 [thread overview]
Message-ID: <20130720181804.459d80fd@opensuse.site> (raw)
In-Reply-To: <3516310.x8V9U5xGG7@icedphoenix>
В Wed, 17 Jul 2013 21:55:58 +0400
Vladimir Testov <vladimir.testov@rosalab.ru> пишет:
> See screenshots included.
>
> If the center slice is NULL then west or north slice is also NULL
Why? As far as I can tell code is supposed to scale all parts of
bitmap. What triggers this problem?
> so the
> height_n or width_w is also NULL. We can count these values from raw (non-
> scaled) bitmaps. The values will be the same as before for common cases. And
> the bug will be fixed.
>
This looks more like a workaround for some other problem. Also while
currently width (for W) or height (for N) does not change, it may be
reimplemented in the future. In this case this patch will create hard
to spot bug.
next prev parent reply other threads:[~2013-07-20 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-17 17:55 [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice Vladimir Testov
2013-07-20 14:18 ` Andrey Borzenkov [this message]
2013-07-22 7:36 ` Vladimir Testov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130720181804.459d80fd@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).