From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V0Xz8-0006PU-Kc for mharc-grub-devel@gnu.org; Sat, 20 Jul 2013 10:18:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Xz6-0006PN-07 for grub-devel@gnu.org; Sat, 20 Jul 2013 10:18:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V0Xz4-0000h8-IF for grub-devel@gnu.org; Sat, 20 Jul 2013 10:18:07 -0400 Received: from mail-lb0-x231.google.com ([2a00:1450:4010:c04::231]:41327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V0Xz4-0000ga-8c for grub-devel@gnu.org; Sat, 20 Jul 2013 10:18:06 -0400 Received: by mail-lb0-f177.google.com with SMTP id 10so4076522lbf.8 for ; Sat, 20 Jul 2013 07:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; bh=uk8B32mFwRu1OFv4D70GOJvC2sekxe/8Q96Qy+2U4yQ=; b=V6j/UNXRoT0Lpg/dOOBN3ZXpeHASTstRoVgj6b7F2bdb+TwRB0Lo/GCfTaFVUd9/sQ kgHkBrgp4FEe72a4d4jLTGMTKweHT2uTvs9zyWSN14PzvJJsEFjzhtxQvLJfD2VuSKjG ba9hgqlLnyUWBE82QaKLi7J7R62ctIalDailUzDQPu7SDSoPTtZan9O/OUE5Y8W6Q0aC 9eBiaxOJ51jodMjG9xscJjHdg74pTGl2gFtyGckLRkjhptwNIVy0lC//xJ8DkNI22vlA FKc2Ivyyw/UQ4FGdq8sCE7qj/ERtuyFtcJat7A1XZk2LrOTJ6zeO2QhTqC9qrBSRLH9q azUg== X-Received: by 10.112.97.132 with SMTP id ea4mr9098259lbb.80.1374329885093; Sat, 20 Jul 2013 07:18:05 -0700 (PDT) Received: from opensuse.site (ppp79-139-160-84.pppoe.spdop.ru. [79.139.160.84]) by mx.google.com with ESMTPSA id et10sm7796790lbc.6.2013.07.20.07.18.04 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 20 Jul 2013 07:18:04 -0700 (PDT) Date: Sat, 20 Jul 2013 18:18:04 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] grub-core/gfxmenu/widget-box.c - bugfix: incorrect drawing in cases of NULL center slice Message-ID: <20130720181804.459d80fd@opensuse.site> In-Reply-To: <3516310.x8V9U5xGG7@icedphoenix> References: <3516310.x8V9U5xGG7@icedphoenix> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2013 14:18:10 -0000 В Wed, 17 Jul 2013 21:55:58 +0400 Vladimir Testov пишет: > See screenshots included. > > If the center slice is NULL then west or north slice is also NULL Why? As far as I can tell code is supposed to scale all parts of bitmap. What triggers this problem? > so the > height_n or width_w is also NULL. We can count these values from raw (non- > scaled) bitmaps. The values will be the same as before for common cases. And > the bug will be fixed. > This looks more like a workaround for some other problem. Also while currently width (for W) or height (for N) does not change, it may be reimplemented in the future. In this case this patch will create hard to spot bug.