From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1V2P09-0008TI-Ps for mharc-grub-devel@gnu.org; Thu, 25 Jul 2013 13:06:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32872) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2P06-0008Os-WF for grub-devel@gnu.org; Thu, 25 Jul 2013 13:06:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V2P04-0003oM-R5 for grub-devel@gnu.org; Thu, 25 Jul 2013 13:06:50 -0400 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:42911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V2P04-0003o8-Kp for grub-devel@gnu.org; Thu, 25 Jul 2013 13:06:48 -0400 Received: by mail-la0-f53.google.com with SMTP id fj20so1554372lab.26 for ; Thu, 25 Jul 2013 10:06:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; bh=M8PZWGozVw+V+a2lFacj3LsxvSsxmvLjCyY96Q91UDU=; b=Jjci4mo2x1uCXLzVK7d+C3bMSmJLz4KXuUrUsiclWCXVckf5mIDYiXIlVmpn+hk5fv rJQhu7XDFjU2xIbHmbCj9A7Dp7tYs/UemNfw0ZvI5mLodDXf4sWoY/2zEIkLB5Yz2frp XEaQVhwnt5YKwvMWZIZbUYQL8NM+ScwnxEWWfbkIePwXod8yFTyfPWQXVZkI2fGNTlLt lMCdyTxyn/DJbdyOuVJs1qoxdv4wiPmMc+VImRAgUEdJeE2E177sd25JrNIHSiMzIfmm /iA18XGLVo1YDq1cq3TBRhhZEkswFb/qtJ2NN6xUk8xUrOI1ANov0YxT80ujNbbBSB4y etYQ== X-Received: by 10.112.167.136 with SMTP id zo8mr18598735lbb.33.1374772007293; Thu, 25 Jul 2013 10:06:47 -0700 (PDT) Received: from opensuse.site (ppp79-139-160-84.pppoe.spdop.ru. [79.139.160.84]) by mx.google.com with ESMTPSA id 8sm16777026lbq.4.2013.07.25.10.06.46 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Thu, 25 Jul 2013 10:06:46 -0700 (PDT) Date: Thu, 25 Jul 2013 21:06:45 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] enable emuusb and emupci on emu platform only Message-ID: <20130725210645.100a1ae5@opensuse.site> In-Reply-To: <51F139B8.7000500@gmail.com> References: <1374389627-26694-1-git-send-email-arvidjaar@gmail.com> <51F139B8.7000500@gmail.com> X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.18; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::235 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Jul 2013 17:06:52 -0000 =D0=92 Thu, 25 Jul 2013 16:44:08 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 21.07.2013 08:53, Andrey Borzenkov wrote: > > Is there any reason we may want to build them when not building > > --with-platform=3Demu? > > > I think it's better to reset COND_EMU_PCI/COND_EMU_USB to false in=20 > configure state when not compiling for emu as usage of both enable and=20 > consition simultaneously is marginal and it's beter not to rely on it=20 > (so to i.a. permit its removal if necessary) I think it makes sense to use both. "enable =3D emu" makes it obvious that module should not be built on other platform. It also makes resulting Makefile.am slightly more readable. Actually it is already used this way for SDL. Like this? diff --git a/configure.ac b/configure.ac index 4fe20a3..acd37f2 100644 --- a/configure.ac +++ b/configure.ac @@ -949,6 +949,13 @@ fi AC_SUBST([enable_grub_emu_sdl]) AC_SUBST([enable_grub_emu_usb]) AC_SUBST([enable_grub_emu_pci]) + +else + +# Ignore --enable-emu-* if platform is not emu +enable_grub_emu_sdl=3Dno +enable_grub_emu_usb=3Dno +enable_grub_emu_pci=3Dno fi =20 AC_ARG_ENABLE([grub-mkfont], diff --git a/grub-core/Makefile.core.def b/grub-core/Makefile.core.def index 06617d7..230bed5 100644 --- a/grub-core/Makefile.core.def +++ b/grub-core/Makefile.core.def @@ -477,6 +477,7 @@ module =3D { module =3D { name =3D emuusb; common =3D bus/usb/usb.c; + enable =3D emu; condition =3D COND_GRUB_EMU_USB; }; =20 @@ -546,6 +547,7 @@ module =3D { common =3D bus/emu/pci.c; common =3D commands/lspci.c; =20 + enable =3D emu; condition =3D COND_GRUB_EMU_PCI; }; =20