From: Andrey Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Franz Hsieh <franz.hsieh@canonical.com>, cjwatson@ubuntu.com
Subject: Re: [RFC][PATCH] Allow hotkeys to interrupt hidden menu
Date: Thu, 12 Sep 2013 06:44:19 +0400 [thread overview]
Message-ID: <20130912064419.125c0bfa@opensuse.site> (raw)
In-Reply-To: <20130911131804.GA10979@riva.ucam.org>
В Wed, 11 Sep 2013 14:18:04 +0100
Colin Watson <cjwatson@ubuntu.com> пишет:
>
> +int
> +grub_menu_get_hotkey (void)
> +{
> + char *val;
> + int hotkey;
> +
> + val = grub_env_get ("hotkey");
> + if (! val)
> + return -1;
> +
> + grub_error_push();
> +
> + hotkey = (int) grub_strtoul (val, 0, 10);
> +
> + /* If the value is invalid, unset the variable. */
Why only if invalid? This is one time event which should be reset as
soon as it is consumed.
Actually I'm not sure if user visible environment variable is needed at
all - just make it a global variable in normal.mod.
next prev parent reply other threads:[~2013-09-12 2:44 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 13:18 [RFC][PATCH] Allow hotkeys to interrupt hidden menu Colin Watson
2013-09-11 13:31 ` Colin Watson
2013-09-12 2:40 ` Andrey Borzenkov
2013-09-13 9:18 ` Franz Hsieh
2013-09-19 6:28 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-10-02 8:03 ` Franz Hsieh
2013-10-02 8:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-10-14 6:02 ` Franz Hsieh
2013-10-21 6:45 ` Franz Hsieh
2013-11-04 3:10 ` Yang Bai
2013-11-27 23:40 ` Colin Watson
2013-11-28 2:30 ` Colin Watson
2013-11-28 6:19 ` Vladimir 'phcoder' Serbinenko
2013-11-28 11:04 ` Colin Watson
2013-11-28 14:08 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-29 16:18 ` Colin Watson
2013-11-29 16:56 ` Andrey Borzenkov
2013-11-29 17:20 ` Colin Watson
2013-11-29 17:29 ` [PATCH] document sleep command exit codes Andrey Borzenkov
2013-11-30 10:39 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-28 17:20 ` [RFC][PATCH] Allow hotkeys to interrupt hidden menu Andrey Borzenkov
2013-11-28 18:05 ` Colin Watson
2013-11-29 6:17 ` Andrey Borzenkov
2013-11-29 15:26 ` Colin Watson
2013-11-28 17:22 ` Andrey Borzenkov
2013-11-28 18:06 ` Colin Watson
2013-11-29 6:21 ` Andrey Borzenkov
2013-09-12 2:44 ` Andrey Borzenkov [this message]
2013-09-12 13:17 ` Colin Watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912064419.125c0bfa@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=cjwatson@ubuntu.com \
--cc=franz.hsieh@canonical.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).