grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [RFC] grub-install C rewrite
Date: Thu, 26 Sep 2013 09:35:04 -0400	[thread overview]
Message-ID: <20130926133504.GQ13097@csclub.uwaterloo.ca> (raw)
In-Reply-To: <524431E6.60807@gmail.com>

On Thu, Sep 26, 2013 at 03:08:54PM +0200, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Hello, all. Recently I made some order in hostdisk.c and getroot.c
> involving splitting in OS-specific parts.
> In the same time I added WinAPI version of getroot/hostdisk allowing
> grub-probe to work on windows natively
> Also on-going is AROS-specific parts.
> Windows and AROS are not friendly with bash.
> The attempt to make both multiple files of same type work and handling
> whitespaces/newlines/... in filenames would result in very ugly code
> with loads of evals.
> Current code may have subtle assumptions on behaviour of common tools
> like sed and on locale (E.g. "[a-z]" doesn't cover u if locale is Estonian).
> So to check viability I rewrote grub-install in C. This is mostly proof
> of concept with loads of FIXMEs but I could boot i386-pc install made
> with it. In many aspects (static variables, some tests, general
> structure) it's reminiscent of sh version of grub-install it's based on.
> Some functionality is likely to stay OS-specific, e.g. executing
> compressors or determining firmware.
> 
> I'd like to know the opinion of other people on possible switchover. If
> switched then it'll have to be all grub-install, grub-mkrescue,
> grub-mknetdir and grub-mkstandalone.
> I'd like to hear from other people.

Given the number of times I have had to edit grub-install in the past to
get it to work right on a powerpc machine (I think it is now working OK),
I would hate to have had that be C code.  After all it really is mainly
a wrapper around other grub tools.

I think windows not having bash is a rather low priority to most people
compared to actually be able to work with grub on the platforms where
it is pretty much the only choice.

So personally, based on my experience, I hate this idea.

-- 
Len Sorensen


  reply	other threads:[~2013-09-26 13:35 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-26 13:08 [RFC] grub-install C rewrite Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-26 13:35 ` Lennart Sorensen [this message]
2013-09-26 13:59   ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-26 14:44     ` Lennart Sorensen
2013-09-26 18:49       ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-26 20:22         ` Lennart Sorensen
2013-09-26 20:29           ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-26 20:51           ` Chris Murphy
2013-09-26 22:15             ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-27  3:10         ` Andrey Borzenkov
2013-09-26 17:10   ` Seth Goldberg
2013-09-26 18:51     ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-09-26 18:56       ` Darren J Moffat
2013-09-26 18:57       ` Seth Goldberg
2013-09-26 14:49 ` Andrey Borzenkov
2013-09-26 15:01   ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-10-06 14:54 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-10-06 15:56   ` Andrey Borzenkov
2013-10-06 18:05     ` Vladimir 'φ-coder/phcoder' Serbinenko
  -- strict thread matches above, loose matches on Subject: below --
2013-09-26 17:52 Kalamatee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130926133504.GQ13097@csclub.uwaterloo.ca \
    --to=lsorense@csclub.uwaterloo.ca \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).