From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VaSCo-0005FO-6K for mharc-grub-devel@gnu.org; Sun, 27 Oct 2013 11:24:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57734) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaSCh-0005FG-Ou for grub-devel@gnu.org; Sun, 27 Oct 2013 11:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VaSCd-0003QI-1U for grub-devel@gnu.org; Sun, 27 Oct 2013 11:24:35 -0400 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:55310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VaSCc-0003QA-P1 for grub-devel@gnu.org; Sun, 27 Oct 2013 11:24:30 -0400 Received: by mail-la0-f41.google.com with SMTP id el20so4481651lab.14 for ; Sun, 27 Oct 2013 08:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=yLg/3NowoBMbvlCmp5Ej+8dlJfhVSRpPa3aY27S+PC4=; b=hXBw2i/6m4JHzHAOjBM2r9RQ/xSCXTvE+nPuUPjpaafR0JXcgufDCVkRe7EZwNleQG 2iSqIvuZXaGPTALJW8WgDmN1ecsTr5Dt0PIBqSVXAM3KJfTgtUteyqOxhj+wu7a2OXwX 9qimCW19/6aHblLrv9dPpJO/wCMP0uRuY0P7Bi/U59E+4iGuWLIMyJ2WDUlZD84dR9xH hnAeVE6HTJVPicb1tergbqIrYVtKMNp3DpBIzsqLQ96LrRdRbYL4F1fzvBNKR3kObJ5M Hu7DdvZPplIFluqeG9Q6siwkcgOWx9QikN05CghMIjX70ysuPqUK2vFkJ6FRLdA3slAR v04w== X-Received: by 10.112.143.166 with SMTP id sf6mr8045469lbb.29.1382887469445; Sun, 27 Oct 2013 08:24:29 -0700 (PDT) Received: from opensuse.site (ppp91-76-150-246.pppoe.mtu-net.ru. [91.76.150.246]) by mx.google.com with ESMTPSA id o1sm16751559lah.8.2013.10.27.08.24.28 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sun, 27 Oct 2013 08:24:28 -0700 (PDT) Date: Sun, 27 Oct 2013 19:24:28 +0400 From: Andrey Borzenkov To: Gene Czarcinski Subject: Re: BUGS: btrfs multi-device support fixes Message-ID: <20131027192428.5fe0ef59@opensuse.site> In-Reply-To: <526D2791.9050308@gmail.com> References: <526BE17E.1060802@czarc.net> <526BED74.6050502@gmail.com> <526C2313.9000703@gmail.com> <20131027105404.7bdc8507@opensuse.site> <526D2791.9050308@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.18; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::229 Cc: Chris Murphy , The development of GNU GRUB , Gene Czarcinski , Vladimir =?UTF-8?B?J8+GLWNvZGVyL3BoY29kZXIn?= Serbinenko X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Oct 2013 15:24:40 -0000 =D0=92 Sun, 27 Oct 2013 10:47:45 -0400 Gene Czarcinski =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > On 10/27/2013 02:54 AM, Andrey Borzenkov wrote: > > =D0=92 Sat, 26 Oct 2013 16:16:19 -0400 > > Gene Czarcinski =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > > >> On 10/26/2013 12:27 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko wro= te: > >>> Rejected, similar patches is in trunk since some time. > >> Thanks. I was not aware that the problem had been addressed. Can you > >> point me where to look to see what has been addressed? > >> > > This is commit 588744d0dc655177d5883bdcb8f72ff5160109ed. > And that sure looks like something I would expect to see from a git=20 > repository! >=20 > Look, I am not stupid but I sure am confused! The grub2 website=20 > (http://www.gnu.org/software/grub/) says that all grub2 development done= =20 > through bazaar repository and that you get a copy of the latest grub2=20 > source with: | > bzr branch http://bzr.savannah.gnu.org/r/grub/trunk/grub| > Well, I tried doing that and all I get is an error saying: "bzr: ERROR:=20 > Not a branch:" >=20 That's where website lags behind. GRUB switched to GIT a while ago. See https://savannah.gnu.org/git/?group=3Dgrub As for web site - I do not know; Vladimir, who can edit this? > Now fedora has a local git repository for grub2 located here:=20 > git://pkgs.fedoraproject.org/grub2.git and when I look at what is there=20 > I see that the updates (when they come in) appear to be in git format. >=20 > On other little thing. I I sent this current message there were TWO bug= =20 > fixes (TWO patch files). I well believe that the first one was already=20 > in trunk since I had originally reported that problem in January 2013. =20 > The reason I reported it again is because it had not been pick up by fedo= ra. >=20 > However, there is that second bug fix which I only recently found and=20 > fixed. This problem occurs when you have /boot on BTRFS either as a=20 > separate subvolume or simply as directory under the root subvolume. In=20 > 10_linux, when grub2-probe is call for hint, it returns multi-device=20 > hints separated by "\n" which completely screws things up. The patch is: > diff --git a/util/grub-probe.c b/util/grub-probe.c > index a46f0b1..dd5de00 100644 > --- a/util/grub-probe.c > +++ b/util/grub-probe.c > @@ -543,7 +543,7 @@ probe (const char *path, char **device_names, char=20 > delim) > print_full_name (map, dev); > printf ("' "); > } > - printf ("\n"); > + printf (" "); /* new-line causes problems for multi-device btrfs=20 > volumes */ >=20 > grub_device_close (dev); > continue;