Re: Install_c merge intention

[Andrey Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1758 bytes --]

В Sun, 10 Nov 2013 16:38:09 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 10.11.2013 15:52, Andrey Borzenkov wrote:
> > В Sat, 09 Nov 2013 13:51:09 +0100
> > Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> > 
> >> Hello, all. install_c is feature complete and I intent to make it
> >> upstream unless issues are raised until 16 Nov. It's available under
> >> http://git.savannah.gnu.org/cgit/grub.git/log/?h=phcoder/install_c
> >>
> > 
> > As was discussed before
> > 
> > - shell grub-istall provides relatively easy way to track what is done
> >   (which modules are selected etc). Binary grub-install does not. It
> >   was suggested to enable easy access to this information (like echoing
> >   invocations of grub-mkimage and grub-setup). This is missing
> >   currently. 
> >
> I added it.  Is the one I added enough?
> 

Yes, thank you. May be having basic verbose level that just prints them
would be better, but that's something that can be implemented later.

> > - looks like shell backticks in /etc/default/grub are not evaluated or
> >   I missed it. Only normal shell quoting is interpreted.
> > 
> There are 2 routines for loading config: Use sh helper or read directly.
> We use sh helper when on unix-like OS and sh is available.

Yes, I missed it.

> > - I guess before merging obsolete shell commands should be removed?
> >   They are still present.
> > 
> Yes, it's to avoid messing with conflicts in deleted files. They'll be
> removed in merge
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> > 
> 
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]