From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VjqbU-0006Qm-9a for mharc-grub-devel@gnu.org; Fri, 22 Nov 2013 08:17:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjqbR-0006QO-Nh for grub-devel@gnu.org; Fri, 22 Nov 2013 08:16:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjqbQ-0003gd-EB for grub-devel@gnu.org; Fri, 22 Nov 2013 08:16:57 -0500 Received: from v6.chiark.greenend.org.uk ([2001:ba8:1e3::]:48853 helo=chiark.greenend.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjqbQ-0003gZ-8P for grub-devel@gnu.org; Fri, 22 Nov 2013 08:16:56 -0500 Received: from [172.20.153.9] (helo=riva.pelham.vpn.ucam.org) by chiark.greenend.org.uk (Debian Exim 4.72 #1) with esmtps (return-path cjwatson@ubuntu.com) id 1VjqbO-0003hA-VQ for grub-devel@gnu.org; Fri, 22 Nov 2013 13:16:55 +0000 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1VjqbO-00056K-92 for grub-devel@gnu.org; Fri, 22 Nov 2013 13:16:54 +0000 Date: Fri, 22 Nov 2013 13:16:53 +0000 From: Colin Watson To: grub-devel@gnu.org Subject: Re: grub2 boot root-on-zfs errors Message-ID: <20131122131652.GA19341@riva.ucam.org> References: <528F0806.5000004@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <528F0806.5000004@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:ba8:1e3:: X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2013 13:16:59 -0000 On Fri, Nov 22, 2013 at 08:30:14AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 22.11.2013 08:09, Beeblebrox wrote: > > grub-core/osdep/unix/platform.c:34:28: error: use of undeclared > > identifier 'PATH_MAX' > > char *ret = xmalloc (2 * PATH_MAX); > Please try > diff --git a/grub-core/osdep/unix/platform.c > b/grub-core/osdep/unix/platform.c > index 65c93f1..a527a1c 100644 > --- a/grub-core/osdep/unix/platform.c > +++ b/grub-core/osdep/unix/platform.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > > static char * > get_ofpathname (const char *dev) > This will not be sufficient to build on GNU/Hurd (get_ofpathname isn't directly relevant to that platform, but that function will be compiled there anyway). We need to avoid the use of PATH_MAX entirely, per: https://www.gnu.org/software/hurd/hurd/porting/guidelines.html -- Colin Watson [cjwatson@ubuntu.com]