[PATCH] Enable grub-install --no-nvram option for EFI targets

[PATCH] Enable grub-install --no-nvram option for EFI targets

[Keshav Padram Amburay]

[-- Attachment #1.1: Type: text/plain, Size: 234 bytes --]

Hi,
     The attached patch enables --no-nvram option for EFI targets in
grub-install so that it is possible to prevent grub-install from create a
boot entry using efibootmgr in non-removable EFI installs.

With Best Regards,

Keshav

[-- Attachment #1.2: Type: text/html, Size: 356 bytes --]

[-- Attachment #2: grub-add-no-nvram-to-efi-install.patch --]
[-- Type: text/x-patch, Size: 1660 bytes --]

commit 307c6b4440562245d2adfcc585b4175ef9c61260
Author: Keshav Padram Amburay <the.ridikulus.rat@gmail.com>
Date:   Fri Nov 22 00:26:37 2013 +0530

    * util/grub-install.c (update_nvram): Support --no-nvram flag
    in EFI targets to prevent grub-install from creating entry using
    efibootmgr in non-removable EFI installs

diff --git a/ChangeLog b/ChangeLog
index 6d4b5b2..e54674b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2013-11-22  Keshav Padram Amburay <the.ridikulus.rat@gmail.com>
+
+	* util/grub-install.c (update_nvram): Support --no-nvram flag
+	in EFI targets to prevent grub-install from creating entry using
+	efibootmgr in non-removable EFI installs
+
 2013-11-21  Colin Watson  <cjwatson@ubuntu.com>
 
 	* util/grub-mkrescue.c (main): If a source directory is not
diff --git a/util/grub-install.c b/util/grub-install.c
index 78e9a04..72e8957 100644
--- a/util/grub-install.c
+++ b/util/grub-install.c
@@ -233,7 +233,7 @@ static struct argp_option options[] = {
       "This option is only available on BIOS target."), 2},
   {"no-nvram", OPTION_NO_NVRAM, 0, 0,
    N_("don't update the `boot-device' NVRAM variable. "
-      "This option is only available on IEEE1275 targets."), 2},
+      "This option is only available on EFI and IEEE1275 targets."), 2},
   {"skip-fs-probe",'s',0,      0,
    N_("do not probe for filesystems in DEVICE"), 0},
   {"no-bootsector", OPTION_NO_BOOTSECTOR, 0, 0,
@@ -1509,7 +1509,7 @@ main (int argc, char *argv[])
 	grub_install_copy_file (imgfile, dst, 1);
 	free (dst);
       }
-      if (!removable)
+      if (!removable && update_nvram)
 	{
 	  char * efidir_disk;
 	  int efidir_part;

Re: [PATCH] Enable grub-install --no-nvram option for EFI targets

[Andrey Borzenkov]

В Fri, 22 Nov 2013 01:01:05 +0530
Keshav Padram Amburay <the.ridikulus.rat@gmail.com> пишет:

>     N_("don't update the `boot-device' NVRAM variable. "
> -      "This option is only available on IEEE1275 targets."), 2},
> +      "This option is only available on EFI and IEEE1275 targets."), 2},

Note that option description is now incorrect. There is no boot-device
on EFI. Could you change wording to be a bit more generic?