grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] fix using grub device name as install device
Date: Fri, 29 Nov 2013 10:52:45 +0400	[thread overview]
Message-ID: <20131129105245.6dd8a92c@opensuse.site> (raw)
In-Reply-To: <529833BA.4030605@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 876 bytes --]

В Fri, 29 Nov 2013 07:27:06 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 28.11.2013 22:11, Andrey Borzenkov wrote:
> > Shell version of grub-install called grub-setup which resolved
> > install device name and called main setup routine. C version of
> > grub-install calls main setup routine directly, which leads
> > to the error:
> > 
> Do you have a reason for continuing accepting such input? It was
> considered wrong way of doing things for quite some while.

Yes - compatibility. At least openSUSE used this syntax during
bootloader configuration (together with maintaining device.map) in past
releases, so anyone updating will inherit it. How do you think I hit it
in the first place? :) And I do not know how many other distros are
affected.

Patch does not add any new feature - it is plain regression fix. 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

  reply	other threads:[~2013-11-29  6:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-28 21:11 [PATCH] fix using grub device name as install device Andrey Borzenkov
2013-11-29  6:27 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-29  6:52   ` Andrey Borzenkov [this message]
2013-11-29  7:18     ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131129105245.6dd8a92c@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).