From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] add grub_qsort_strcmp to use when sorting array of strings
Date: Sat, 30 Nov 2013 14:59:59 +0400 [thread overview]
Message-ID: <20131130145959.0c2f158a@opensuse.site> (raw)
In-Reply-To: <5299C050.4040507@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
В Sat, 30 Nov 2013 11:39:12 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> On 29.11.2013 18:01, Andrey Borzenkov wrote:
> > Compare function used in qsort gets arguments by reference, so strcmp
> > cannot be used directly - it expects pointer to char, but gets pointer
> > to pointer to char.
> >
> > Introduce new helper grub_qsort_strcmp and use it in grub-install.
> > This helper is going to be used in a couple more places as well so
> > add it to global file, not in grub-install.c.
> >
> Nice catch. But I don't we have enough use for grub_qsort_strcmp to make
> it global. Can you make it static in grub-install.c ?
I have pending patches to sort long lists in help output of commands
(grub-mkimage and grub-probe target lists). They are long enough to
wish some ordering.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-11-30 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-29 17:01 [PATCH] add grub_qsort_strcmp to use when sorting array of strings Andrey Borzenkov
2013-11-30 10:39 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-11-30 10:59 ` Andrey Borzenkov [this message]
2013-12-02 5:34 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131130145959.0c2f158a@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).