From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VoCeH-0007js-Ud for mharc-grub-devel@gnu.org; Wed, 04 Dec 2013 08:37:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoCeB-0007ir-Id for grub-devel@gnu.org; Wed, 04 Dec 2013 08:37:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoCe6-000093-NK for grub-devel@gnu.org; Wed, 04 Dec 2013 08:37:47 -0500 Received: from chiark.greenend.org.uk ([212.13.197.229]:37155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoCe6-00008s-Hm for grub-devel@gnu.org; Wed, 04 Dec 2013 08:37:42 -0500 Received: from [172.20.153.9] (helo=riva.pelham.vpn.ucam.org) by chiark.greenend.org.uk (Debian Exim 4.72 #1) with esmtps (return-path cjwatson@ubuntu.com) id 1VoCdj-00027w-Et for grub-devel@gnu.org; Wed, 04 Dec 2013 13:37:19 +0000 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1VoCdi-0006rK-LG for grub-devel@gnu.org; Wed, 04 Dec 2013 13:37:18 +0000 Date: Wed, 4 Dec 2013 13:37:17 +0000 From: Colin Watson To: grub-devel@gnu.org Subject: Re: [PATCH] Fix grub-shell to avoid breaking "make distcheck" Message-ID: <20131204133717.GA25568@riva.ucam.org> References: <20131129141213.GD16321@riva.ucam.org> <529C1D6A.4070600@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <529C1D6A.4070600@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 212.13.197.229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Dec 2013 13:37:52 -0000 On Mon, Dec 02, 2013 at 06:40:58AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > On 29.11.2013 15:12, Colin Watson wrote: > > Copying the themes directory in grub-shell isn't > > parallel-test-friendly and breaks on the second test when the source > > directory is read-only (as in "make distcheck"). Instead, add a > > --themes-directory option to grub-mkrescue et al, and use it in > > grub-shell. > > I agree with the patch but I'm unsure whether --themes-idrectory has to > be a hidden option or appear in --help. I made it a hidden option, merged, and pushed. Thanks. -- Colin Watson [cjwatson@ubuntu.com]