From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1VoXww-0000Oc-74 for mharc-grub-devel@gnu.org; Thu, 05 Dec 2013 07:22:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoXwq-0000OT-SS for grub-devel@gnu.org; Thu, 05 Dec 2013 07:22:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VoXwp-0003Ch-P8 for grub-devel@gnu.org; Thu, 05 Dec 2013 07:22:28 -0500 Received: from v6.chiark.greenend.org.uk ([2001:ba8:1e3::]:43268 helo=chiark.greenend.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VoXwp-0003CY-J1 for grub-devel@gnu.org; Thu, 05 Dec 2013 07:22:27 -0500 Received: from [172.20.153.9] (helo=riva.pelham.vpn.ucam.org) by chiark.greenend.org.uk (Debian Exim 4.72 #1) with esmtps (return-path cjwatson@ubuntu.com) id 1VoXwo-0002LJ-Ut for grub-devel@gnu.org; Thu, 05 Dec 2013 12:22:27 +0000 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1VoXwn-0004Rv-Kn for grub-devel@gnu.org; Thu, 05 Dec 2013 12:22:25 +0000 Date: Thu, 5 Dec 2013 12:22:24 +0000 From: Colin Watson To: grub-devel@gnu.org Subject: Re: [PATCH] On Linux, read partition start offsets from sysfs if possible Message-ID: <20131205122224.GA13669@riva.ucam.org> References: <20131205121723.GN16147@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131205121723.GN16147@riva.ucam.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:ba8:1e3:: X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Dec 2013 12:22:33 -0000 On Thu, Dec 05, 2013 at 12:17:23PM +0000, Colin Watson wrote: > This lets us cope with block device drivers that don't implement > HDIO_GETGEO. Fixes Ubuntu bug #1237519. Brandon Hansen also pointed out in this bug that hd_geometry.start is unsigned long rather than unsigned long long, and thus is not necessarily reliable on large disks, which is a good point I'd overlooked, and should be further support for this approach. -- Colin Watson [cjwatson@ubuntu.com]