From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH 2/2] second attempt to fix using grub device name as install device
Date: Sat, 7 Dec 2013 13:40:22 +0400 [thread overview]
Message-ID: <20131207134022.487abb56@opensuse.site> (raw)
In-Reply-To: <52A2E0B0.2030608@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
В Sat, 07 Dec 2013 09:47:44 +0100
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> On 07.12.2013 09:44, Andrey Borzenkov wrote:
> > + install_device[grub_strlen (install_device) - 1] = '\0';
> > + install_drive = xstrdup (install_device + 1);
> > + install_device[grub_strlen (install_device) - 1] = ')';
> > + }
> Bad code. You forgot that grub_strlen changes with your operations. You
> need to keep explicit pointer.
>
>
Oops. Any reason "our" gnulib is missing xstrndup? It is not the only
place where it will make things more simple and readable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-12-07 9:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 21:39 [PATCH] Fix grub-install with OS device name Colin Watson
2013-12-04 21:54 ` Jonathan McCune
2013-12-04 22:15 ` Colin Watson
2013-12-05 5:56 ` arvidjaar
2013-12-05 7:08 ` Andrey Borzenkov
2013-12-07 8:44 ` [PATCH 1/2] revert 69ca97c820, it broke using OS device name as install device Andrey Borzenkov
2013-12-07 8:44 ` [PATCH 2/2] second attempt to fix using grub " Andrey Borzenkov
2013-12-07 8:47 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-07 9:40 ` Andrey Borzenkov [this message]
2013-12-07 9:42 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-07 10:19 ` [PATCH 2/2 v2] " Andrey Borzenkov
2013-12-07 13:50 ` Vladimir 'φ-coder/phcoder' Serbinenko
2013-12-07 13:59 ` Andrey Borzenkov
2013-12-07 14:14 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131207134022.487abb56@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).