From: Andrey Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: Request a freeze exception for vlantag feature
Date: Thu, 9 Jan 2014 07:05:16 +0400 [thread overview]
Message-ID: <20140109070516.668ad4ba@opensuse.site> (raw)
In-Reply-To: <20140108185727.GA15022@beren.br.ibm.com>
В Wed, 8 Jan 2014 16:57:28 -0200
Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com> пишет:
> +
> + inter->vlantag.pcp = vlantag >> 12;
> + inter->vlantag.dei = (vlantag >> 11) & 0x1;
> + inter->vlantag.vid = vlantag & 0x1fff;
That's 13 bits, not 12, right? And this really looks like
overengeneering - do you really want to be able to set static VLAN
priority bits? I do not think it belongs to grub.
> +
> + if (grub_strcmp (args[3], "vlan") == 0)
> + vlan_pos = 3;
> +
> + if (grub_strcmp (args[4], "vlan") == 0)
> + vlan_pos = 4;
May be it should really start using proper options at this point
keeping existing three argument form as legacy.
net_add_addr --if=... --addr=... --mask=... --vlan=... --hw=... card
next prev parent reply other threads:[~2014-01-09 3:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 16:34 Request a freeze exception for vlantag feature Paulo Flabiano Smorigo/Brazil/IBM
2013-12-23 17:02 ` Andrey Borzenkov
2013-12-26 17:25 ` pfsmorigo
2014-01-08 18:57 ` Paulo Flabiano Smorigo
2014-01-09 3:05 ` Andrey Borzenkov [this message]
2014-01-09 16:58 ` Paulo Flabiano Smorigo
2014-01-14 19:01 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-15 5:18 ` Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140109070516.668ad4ba@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).