From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W15wD-00049p-89 for mharc-grub-devel@gnu.org; Wed, 08 Jan 2014 22:05:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W15w1-00048f-B8 for grub-devel@gnu.org; Wed, 08 Jan 2014 22:05:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W15vs-0003lX-Rr for grub-devel@gnu.org; Wed, 08 Jan 2014 22:05:29 -0500 Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:58253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W15vs-0003ke-JQ for grub-devel@gnu.org; Wed, 08 Jan 2014 22:05:20 -0500 Received: by mail-lb0-f178.google.com with SMTP id c11so1878082lbj.23 for ; Wed, 08 Jan 2014 19:05:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; bh=700tReNxHMaisCgbfp3dsr+JZhkO2Xdqudolg14aDRw=; b=062/czNC6NhYEQbmdQCIkhQBFJLDOa2k0uhV24b4dnbN+lB1iBWeKay6mqOaSZXfB9 8d4bkJIter6QGvVHz/naA42k9F4acTmZe32N6I3OI+mxFnwUgCdia1Xi2npbF3Q+OYd+ mZsx6bpcvTr+Uk3vZwmfk6YqbgPyyh1nqEfZl+tEPP3RHVnAJ1EsfD0BabDlzrOZz9Ll p224Ncq9kmkAaBEHvq+0OgU8qNrQx/I1QQSquJpHo49/r4WVRpGaHxI9+KIICiYFe/L1 +kHszJp4zRAItL/aphdOonz8ZO9XucUS6MgAjYBln6VvZLX4+Zr0w45ZiisjMEdyg4Sv aY1A== X-Received: by 10.152.45.8 with SMTP id i8mr247513lam.12.1389236717814; Wed, 08 Jan 2014 19:05:17 -0800 (PST) Received: from opensuse.site (ppp91-76-134-134.pppoe.mtu-net.ru. [91.76.134.134]) by mx.google.com with ESMTPSA id xl4sm438151lac.9.2014.01.08.19.05.17 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 08 Jan 2014 19:05:17 -0800 (PST) Date: Thu, 9 Jan 2014 07:05:16 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: Request a freeze exception for vlantag feature Message-ID: <20140109070516.668ad4ba@opensuse.site> In-Reply-To: <20140108185727.GA15022@beren.br.ibm.com> References: <20131223113410.Horde.LfYohJir309SuGYCUmW1mHA@imap.linux.ibm.com> <1387818177.918.31.camel@opensuse.site> <20131226172524.GA8868@beren.lan> <20140108185727.GA15022@beren.br.ibm.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::232 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jan 2014 03:05:37 -0000 В Wed, 8 Jan 2014 16:57:28 -0200 Paulo Flabiano Smorigo пишет: > + > + inter->vlantag.pcp = vlantag >> 12; > + inter->vlantag.dei = (vlantag >> 11) & 0x1; > + inter->vlantag.vid = vlantag & 0x1fff; That's 13 bits, not 12, right? And this really looks like overengeneering - do you really want to be able to set static VLAN priority bits? I do not think it belongs to grub. > + > + if (grub_strcmp (args[3], "vlan") == 0) > + vlan_pos = 3; > + > + if (grub_strcmp (args[4], "vlan") == 0) > + vlan_pos = 4; May be it should really start using proper options at this point keeping existing three argument form as legacy. net_add_addr --if=... --addr=... --mask=... --vlan=... --hw=... card