From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2FWn-0002Cz-HY for mharc-grub-devel@gnu.org; Sun, 12 Jan 2014 02:32:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2FWd-0002CE-Nu for grub-devel@gnu.org; Sun, 12 Jan 2014 02:32:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2FWV-0000jq-A1 for grub-devel@gnu.org; Sun, 12 Jan 2014 02:32:03 -0500 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:52447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2FWU-0000ji-So for grub-devel@gnu.org; Sun, 12 Jan 2014 02:31:55 -0500 Received: by mail-la0-f49.google.com with SMTP id y1so283824lam.8 for ; Sat, 11 Jan 2014 23:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=8YttDpvysf9V5Y3r7C/B4KyOXde75M3pfqp7uInotto=; b=iP5U6okOdzq9HIIdT3NIOHi7KH5R3w+FSHqTakQt4DuMYOi+KH9iomplGZ3rVEtEb4 AMr3wgHC9HxuUxPGi0iE3+HAVu5vO6fr9xdpUIueHBMaNiiqcTROozVCdQ5JMGNwPrxf 32lr4qvo119a/7iA5eAXXYMNIMAmHQaWaDGT39okSdIB7NEWqhU49OC8Efgtbql51Hg2 lgQWbmE8p3zki2UgJnNAvpviat+XC5rdIjOu/u6jnwYr4Ri20nVXfUTuCGH3DQAWk36p obHgmCgtIFy6Z7yBDd2xzNFNWmBE0GSDHRCdJrTaco2NN+8BK5Zj3CVt/YtD+PsNMt39 ufWA== X-Received: by 10.152.25.226 with SMTP id f2mr356787lag.14.1389511913214; Sat, 11 Jan 2014 23:31:53 -0800 (PST) Received: from opensuse.site (ppp91-76-163-241.pppoe.mtu-net.ru. [91.76.163.241]) by mx.google.com with ESMTPSA id tc8sm6954636lbb.9.2014.01.11.23.31.51 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 11 Jan 2014 23:31:51 -0800 (PST) Date: Sun, 12 Jan 2014 11:31:47 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] add part_apple to EFI rescue image to fix missing prefix Message-ID: <20140112113147.246fa792@opensuse.site> In-Reply-To: <52D15BFC.8070509@gmail.com> References: <1389119495-4399-1-git-send-email-arvidjaar@gmail.com> <52D15BFC.8070509@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/dDTK5b4VJOhoSgngqFv=BCt"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Jan 2014 07:32:12 -0000 --Sig_/dDTK5b4VJOhoSgngqFv=BCt Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sat, 11 Jan 2014 15:58:04 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 07.01.2014 19:31, Andrey Borzenkov wrote: > > On Mac rescue image is booted from HFS+ partition, so bootpath looks li= ke > > /ACPI(a0341d0,0)/PCI(1,1f)/ATAPI(0,0,0)/HD(3,5d1,ca3,0000000000000000,2= 0,0)/EndEntire > >=20 > > grub fails to find device for this path because it cannot scan partition > > table. The simplest fix is to add part_apple by default. > >=20 > > --- > > util/grub-mkrescue.c | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c > > index 0d03e55..30bb701 100644 > > --- a/util/grub-mkrescue.c > > +++ b/util/grub-mkrescue.c > > @@ -316,9 +316,11 @@ make_image_fwdisk_abs (enum grub_install_plat plat, > > fclose (load_cfg_f); > > =20 > > grub_install_push_module ("iso9660"); > > + grub_install_push_module ("part_apple"); > > grub_install_make_image_wrap (source_dirs[plat], "()/boot/grub", out= put, > > 0, load_cfg, mkimage_target, 0); > > grub_install_pop_module (); > > + grub_install_pop_module (); > This needs to be either limited to the 3 platforms in question > (powerpc-ieee1275, i386-efi, x86_64-efi) or extended to all platforms. I > prefer former. Like below? From: Andrey Borzenkov Subject: [PATCH] add part_apple to EFI rescue image to fix missing prefix On Mac rescue image is booted from HFS+ partition, so bootpath looks like /ACPI(a0341d0,0)/PCI(1,1f)/ATAPI(0,0,0)/HD(3,5d1,ca3,0000000000000000,20,0)= /EndEntire grub fails to find device for this path because it cannot scan partition table. The simplest fix is to add part_apple by default. --- util/grub-mkrescue.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/util/grub-mkrescue.c b/util/grub-mkrescue.c index 0d03e55..34e0b7a 100644 --- a/util/grub-mkrescue.c +++ b/util/grub-mkrescue.c @@ -653,11 +653,15 @@ main (int argc, char *argv[]) make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_IA64_EFI, "ia64-efi", i= mgname); free (imgname); =20 + grub_install_push_module ("part_apple"); img64 =3D grub_util_path_concat (2, efidir_efi_boot, "bootx64.efi"); make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_X86_64_EFI, "x86_64-efi= ", img64); + grub_install_pop_module (); =20 + grub_install_push_module ("part_apple"); img32 =3D grub_util_path_concat (2, efidir_efi_boot, "bootia32.efi"); make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_I386_EFI, "i386-efi", i= mg32); + grub_install_pop_module (); =20 imgname =3D grub_util_path_concat (2, efidir_efi_boot, "bootarm.efi"= ); make_image_fwdisk_abs (GRUB_INSTALL_PLATFORM_ARM_EFI, "arm-efi", img= name); @@ -707,7 +711,9 @@ main (int argc, char *argv[]) free (efidir); } =20 + grub_install_push_module ("part_apple"); make_image_fwdisk (GRUB_INSTALL_PLATFORM_POWERPC_IEEE1275, "powerpc-ieee= 1275", "powerpc-ieee1275/core.elf"); + grub_install_pop_module (); =20 if (source_dirs[GRUB_INSTALL_PLATFORM_POWERPC_IEEE1275]) { --=20 tg: (e7cfa8d..) u/apple-boot-path (depends on: master) --Sig_/dDTK5b4VJOhoSgngqFv=BCt Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlLSROYACgkQR6LMutpd94wAdQCeNckuZO9kR2BC/oyairhQ3Zrg 1AAAnRjoRN+pVcD1L8+4P0suYUxaaMv0 =hvdF -----END PGP SIGNATURE----- --Sig_/dDTK5b4VJOhoSgngqFv=BCt--