From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W2u4O-0005wl-FX for mharc-grub-devel@gnu.org; Mon, 13 Jan 2014 21:49:36 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2u4E-0005wV-Ot for grub-devel@gnu.org; Mon, 13 Jan 2014 21:49:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2u46-0005Gd-Bq for grub-devel@gnu.org; Mon, 13 Jan 2014 21:49:26 -0500 Received: from mail-la0-x229.google.com ([2a00:1450:4010:c03::229]:63862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2u46-0005GZ-4W for grub-devel@gnu.org; Mon, 13 Jan 2014 21:49:18 -0500 Received: by mail-la0-f41.google.com with SMTP id mc6so2053092lab.14 for ; Mon, 13 Jan 2014 18:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=8zWl6l9oMn2pHnUR1z4JTlTk0NZ2Eg35O6aU5IqKODw=; b=bGZOU0Risn3o9pu13pWQY93KGvE7eXaH9PkUtD8uBNQd9qLEtm+G2mg9Fo//Asii2r rWkQ9zuqI5VW/zlD2iVW6Teu5iIet1AOj3067R/lBx7EEYongj5lGXkn1s0TbUvuvMMv x9Cbg+eHpZTj9w1b0gfcoaji6wZ8eVOSjaSzKDxblCckY4Vo3CoQzn2sAsHAv307TVU0 Csew/GxFwgUB+AsjG250pi4grVemtlv3REGqGkOMDY/NzLV2GewbVezYiH7xpE38P8xW b/tjnXfrdty7dxPejSySXRjo+eyfutzqfgKjYr8Co3EKt49e6mLcemmOSKkbr73gFdTX MxKQ== X-Received: by 10.152.120.7 with SMTP id ky7mr86158lab.83.1389667756777; Mon, 13 Jan 2014 18:49:16 -0800 (PST) Received: from opensuse.site (ppp91-76-163-241.pppoe.mtu-net.ru. [91.76.163.241]) by mx.google.com with ESMTPSA id a8sm13625528lae.5.2014.01.13.18.49.15 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 13 Jan 2014 18:49:16 -0800 (PST) Date: Tue, 14 Jan 2014 06:49:12 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: conflicting types for 'grub_list_push' on MinGW (include loop) Message-ID: <20140114064912.57d4c484@opensuse.site> In-Reply-To: <52D461F6.8000702@gmail.com> References: <20140113221705.4fa58f60@opensuse.site> <20140113183341.GA16811@riva.ucam.org> <52D461F6.8000702@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/.r6FoVn5FzDZ7_9hFKsrXmX"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::229 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jan 2014 02:49:35 -0000 --Sig_/.r6FoVn5FzDZ7_9hFKsrXmX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Mon, 13 Jan 2014 23:00:22 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 13.01.2014 19:33, Colin Watson wrote: > > On Mon, Jan 13, 2014 at 10:17:05PM +0400, Andrey Borzenkov wrote: > >> I'm not sure what to do here. list.h needs misc.h apparently only for > >> definition of ATTRIBUTE_ERROR which in turn does not appear to be used > >> anywhere else. This is not fatal so may be can be ignored for now, but > >> still would be nice to clean up. > >=20 > > Maybe we could instead move grub_strtol into grub-core/kern/misc.c, > > after which we'd no longer need to include from > > ? > >=20 > grub_strtol isn't used in core so shouldn't be in kernel. >=20 >=20 Unless there is some redefinition, it seems to be used almost only in core? Is it wrong? bor@opensuse:~/src/grub> grep -rlw grub_strtol . ./grub-core/gfxmenu/gui_circular_progress.c ./grub-core/gfxmenu/gui_list.c ./grub-core/lib/syslinux_parse.c ./include/grub/misc.h ./ChangeLog bor@opensuse:~/src/grub>=20 --Sig_/.r6FoVn5FzDZ7_9hFKsrXmX Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlLUpagACgkQR6LMutpd94x7iACfYuSybGQIVpRoKD/NkEG9/a08 DLwAnjtamL/mxlCzIzsJ9xKe6UbskfDY =UqGh -----END PGP SIGNATURE----- --Sig_/.r6FoVn5FzDZ7_9hFKsrXmX--