grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Colin Watson <cjwatson@ubuntu.com>
To: grub-devel@gnu.org
Subject: [PATCH] grub-shell: Pass -no-pad to xorriso when building floppy images
Date: Thu, 16 Jan 2014 12:49:37 +0000	[thread overview]
Message-ID: <20140116124937.GP5883@riva.ucam.org> (raw)

The floppy images built by grub-shell are currently just over the
floppy limit, and the Debian patch set plus the 915resolution extra
bring this up to the point where GRUB tries to actually read past
the floppy limit, breaking fddboot_test.  Passing -no-pad buys us
300KiB, which should keep us going for a while.

* tests/util/grub-shell.in: Pass -no-pad to xorriso when building
floppy images, saving 300KiB.
---
 ChangeLog                | 5 +++++
 tests/util/grub-shell.in | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index b445f12..c0cc45e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-01-16  Colin Watson  <cjwatson@ubuntu.com>
+
+	* tests/util/grub-shell.in: Pass -no-pad to xorriso when building
+	floppy images, saving about 300KiB.
+
 2014-01-08  Colin Watson  <cjwatson@ubuntu.com>
 
 	* Makefile.util.def (grub-macbless): Change mansection to 8.
diff --git a/tests/util/grub-shell.in b/tests/util/grub-shell.in
index d9a5253..6f13591 100644
--- a/tests/util/grub-shell.in
+++ b/tests/util/grub-shell.in
@@ -346,6 +346,10 @@ if test -z "$debug"; then
   qemuopts="${qemuopts} -nographic -monitor file:/dev/null"
 fi
 
+if [ x$boot = xfd ]; then
+    mkrescue_args="${mkrescue_args} -- -no-pad"
+fi
+
 if [ x$boot != xnet ] && [ x$boot != xemu ]; then
     pkgdatadir="@builddir@" "@builddir@/grub-mkrescue" "--output=${isofile}" "--override-directory=${builddir}/grub-core" \
 	--rom-directory="${rom_directory}" \
-- 
1.8.5.2


             reply	other threads:[~2014-01-16 12:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-16 12:49 Colin Watson [this message]
2014-01-16 14:05 ` grub-shell: Pass -no-pad to xorriso when building floppy images Thomas Schmitt
2014-01-16 14:53   ` Colin Watson
2014-01-16 16:17     ` Thomas Schmitt
2014-01-16 16:28       ` Thomas Schmitt
2014-01-16 18:21         ` Andrey Borzenkov
2014-01-16 18:56       ` Thomas Schmitt
2014-01-16 19:13         ` Andrey Borzenkov
2014-01-16 19:43           ` Thomas Schmitt
2014-01-22 15:12     ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-01-22 15:36       ` Thomas Schmitt
2014-01-25 16:27       ` Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140116124937.GP5883@riva.ucam.org \
    --to=cjwatson@ubuntu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).