From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1W4ZRZ-0005Pi-8a for mharc-grub-devel@gnu.org; Sat, 18 Jan 2014 12:12:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4ZRP-0005PS-DX for grub-devel@gnu.org; Sat, 18 Jan 2014 12:12:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4ZRF-0000Ud-T8 for grub-devel@gnu.org; Sat, 18 Jan 2014 12:12:15 -0500 Received: from mail-la0-x235.google.com ([2a00:1450:4010:c03::235]:56728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4ZRF-0000UT-LC for grub-devel@gnu.org; Sat, 18 Jan 2014 12:12:05 -0500 Received: by mail-la0-f53.google.com with SMTP id e16so4490557lan.40 for ; Sat, 18 Jan 2014 09:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=eO5yn4f/dg1lcSMNBiYPrYmtOrXBELTma+8CVnk/tsw=; b=b+7ODnfSWbPQDyWDKoJCqTkOkYp/CKBwctzFyQyk24J3unMvAdB6NSqyMdjWqGbnle z8L8LpmZLO4wt7P+3/lBX5yNLeOUL4+4Jq7lq9E51gx6y6RBHubuVJFwnsdDIZfasrQw fieHKHBdCBXwN1WsLBBosPwtjPvXGIMMrixNBoob9/5kiAgiUKMbqqnYDnx+STZwYrHg r8cIVyjdListYPd8ggJ0J31yaShYHaAmn3XNWWz06Saj3SjwxP9aTgFjasz5vwflOGwe t46zfAXj+Oh1uFDtcXDRqPqAgWCf0IXVbeCkaRVWq4fc1I+J7Xz0Mat/UdEKPbLadcbm qdiQ== X-Received: by 10.152.170.199 with SMTP id ao7mr1584767lac.40.1390065124473; Sat, 18 Jan 2014 09:12:04 -0800 (PST) Received: from opensuse.site (ppp91-76-163-241.pppoe.mtu-net.ru. [91.76.163.241]) by mx.google.com with ESMTPSA id n13sm9484590lbl.17.2014.01.18.09.12.03 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Sat, 18 Jan 2014 09:12:03 -0800 (PST) Date: Sat, 18 Jan 2014 21:12:02 +0400 From: Andrey Borzenkov To: grub-devel@gnu.org Subject: Re: [PATCH] use MODULE_FILES for genemuinit* instead of MOD_FILES Message-ID: <20140118211202.20f09930@opensuse.site> In-Reply-To: <52DAB20A.106@gmail.com> References: <1390062422-18563-1-git-send-email-arvidjaar@gmail.com> <52DAB20A.106@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/D7prFnBVWA0K1Zd0Gw8C9Xr"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::235 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Jan 2014 17:12:24 -0000 --Sig_/D7prFnBVWA0K1Zd0Gw8C9Xr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sat, 18 Jan 2014 17:55:38 +0100 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 18.01.2014 17:27, Andrey Borzenkov wrote: > > While on it, pass detected > > nm arguments instead of hardcoding them. > please make this part a separate patch. is it OK to commit without this part? > This would indicate that you > support non-portable nm output which in this branch isn't the case. Why > do you need it in the first place? >=20 I do not need it for MinGW case; but it just looks incorrect in general case - first we check nm arguments and then ignore it. I agree that mixing two patches was wrong on my side. --Sig_/D7prFnBVWA0K1Zd0Gw8C9Xr Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlLateIACgkQR6LMutpd94xOJwCgpltzP8NwuK/4gLqDJFNQ/7aU vgcAnRhMThGxybA/zzOSPNbNWo185bmq =Y9A+ -----END PGP SIGNATURE----- --Sig_/D7prFnBVWA0K1Zd0Gw8C9Xr--