From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WV2Dr-0007gQ-V8 for mharc-grub-devel@gnu.org; Tue, 01 Apr 2014 13:11:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV2Dk-0007Nr-OO for grub-devel@gnu.org; Tue, 01 Apr 2014 13:11:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WV2Df-0007tJ-39 for grub-devel@gnu.org; Tue, 01 Apr 2014 13:11:32 -0400 Received: from mail-la0-x22d.google.com ([2a00:1450:4010:c03::22d]:47307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV2De-0007t4-Qu for grub-devel@gnu.org; Tue, 01 Apr 2014 13:11:27 -0400 Received: by mail-la0-f45.google.com with SMTP id hr17so7327449lab.32 for ; Tue, 01 Apr 2014 10:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=0d27Wl528lfOMEekWfrl01GjSISHAB/RPq+nyMkk89A=; b=F+9HOEGV8ACN8jaiCkaZlfOnyJJ8zXc8Ms5EJLWU4fGs4spPXvqkzugXmofI8xi3gz aqKQ54nvRTw/miE55NckOj6zyXVhSRPN4/XbLU+dZUDaG95FayPqMaHsRTUJkjTYlvjD RDFxnDexvwsge25j6ahVYaQWvnD4ZLOaSOg3Jw5vSiRfSJHYZC1y+4OrVfTEy3Jm4gcc Yem+Cbo3pfwJnnsLdqiRqsiZMxKYyB43vXoDmebIQUKDl45LzO596s0kJDc4ITtpdn0B 4GCbxr4Jqd0ISELWU+GSq5idg9wmGaaHnljWjH/9RtZwL7sziLKJw43rOIwnA30Y32Eb SDLw== X-Received: by 10.152.184.66 with SMTP id es2mr23883357lac.22.1396372285920; Tue, 01 Apr 2014 10:11:25 -0700 (PDT) Received: from opensuse.site (ppp37-190-15-130.pppoe.spdop.ru. [37.190.15.130]) by mx.google.com with ESMTPSA id v20sm12505495lbi.24.2014.04.01.10.11.24 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Apr 2014 10:11:25 -0700 (PDT) Date: Tue, 1 Apr 2014 21:11:23 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: [RFC PATCH 06/23] Add IEEE1275_ADDR helper Message-ID: <20140401211123.18704551@opensuse.site> In-Reply-To: <1393439482-20341-7-git-send-email-linuxram@us.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-7-git-send-email-linuxram@us.ibm.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22d Cc: tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, anton@au1.ibm.com, linuxram@us.ibm.com, tonyb@au1.ibm.com, Anton Blanchard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2014 17:11:38 -0000 В Wed, 26 Feb 2014 10:31:05 -0800 Ram Pai пишет: > From: Anton Blanchard > > If the target pointer size doesn't match the IEEE1275 cell size, we > need to cast twice to avoid a warning. > > > > +#define IEEE1275_ADDR(x) (grub_uint32_t)(grub_addr_t)(x) > + Should not this be conditional on sizeof(grub_ieee1275_cell_t)? Otherwise it seems to truncate value on platform where it is 64 bit (sparc64)? Is it possible that pointer does exceed 32 bits?