From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WV2Nu-0003hh-Mr for mharc-grub-devel@gnu.org; Tue, 01 Apr 2014 13:22:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42508) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV2Nm-0003Pl-HU for grub-devel@gnu.org; Tue, 01 Apr 2014 13:22:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WV2Ng-0003Vu-RI for grub-devel@gnu.org; Tue, 01 Apr 2014 13:21:54 -0400 Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:48865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV2Ng-0003VY-JY for grub-devel@gnu.org; Tue, 01 Apr 2014 13:21:48 -0400 Received: by mail-la0-f43.google.com with SMTP id e16so7205867lan.16 for ; Tue, 01 Apr 2014 10:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=KScUuQO5UBc1N9VtlxO8VsA+BstR4tBcPVwCkB9wLx0=; b=i1DdVZWko0tGnieOBSqYjLJLj1UHyCDFrkAmbDn7XkK7g01/LPwX6pTxV0188ClJ7U rXRyoUyl6+DO8+vjdWpGJi8y4ozklUdoj93k47PnUqqKbow6il+gakFmLRFKjtRdI/9r WDlvUDYl4KFtYZppCTkBDZABclk+GEQNgc/4QU9ELZsFGs4G2l6wjhYugobaTmB37COD zycb6zxdSJqZD0Ke05T7bUHaAy1jmeqDlbZfXY4cOFhwPmttwCfjZiwi5bMfHTgRZCbp nBN1o5ChaoPachVn3XsdDId4sZCbxwKpFwgb0I+3LHihMTeRywadehNvvxDxe2ONJH4/ vcZg== X-Received: by 10.112.56.148 with SMTP id a20mr1709861lbq.44.1396372907540; Tue, 01 Apr 2014 10:21:47 -0700 (PDT) Received: from opensuse.site (ppp37-190-15-130.pppoe.spdop.ru. [37.190.15.130]) by mx.google.com with ESMTPSA id j2sm17645279lag.12.2014.04.01.10.21.46 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Apr 2014 10:21:46 -0700 (PDT) Date: Tue, 1 Apr 2014 21:21:46 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: [RFC PATCH 09/23] Fix warnings when building powerpc linux loader 64bit Message-ID: <20140401212146.0d46eb78@opensuse.site> In-Reply-To: <1393439482-20341-10-git-send-email-linuxram@us.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-10-git-send-email-linuxram@us.ibm.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22b Cc: tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, anton@au1.ibm.com, linuxram@us.ibm.com, tonyb@au1.ibm.com, Anton Blanchard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2014 17:22:00 -0000 В Wed, 26 Feb 2014 10:31:08 -0800 Ram Pai пишет: > From: Anton Blanchard > > Fix warnings when building powerpc linux loader 64bit > > Signed-off-by: Ram Pai > From: Anton Blanchard > --- > grub-core/loader/powerpc/ieee1275/linux.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/grub-core/loader/powerpc/ieee1275/linux.c b/grub-core/loader/powerpc/ieee1275/linux.c > index 4a14f66..3d6a61e 100644 > --- a/grub-core/loader/powerpc/ieee1275/linux.c > +++ b/grub-core/loader/powerpc/ieee1275/linux.c > @@ -141,8 +141,8 @@ grub_linux_boot (void) > grub_ieee1275_set_property (grub_ieee1275_chosen, "bootargs", linux_args, > grub_strlen (linux_args) + 1, &actual); > > - grub_dprintf ("loader", "Entry point: 0x%x\n", linux_entry); > - grub_dprintf ("loader", "Initrd at: 0x%x, size 0x%x\n", initrd_addr, > + grub_dprintf ("loader", "Entry point: 0x%lx\n", linux_entry); I guess using PRIxGRUB_ADDR is more consistent - it can now be both 32 and 64 bits. > + grub_dprintf ("loader", "Initrd at: 0x%lx, size 0x%lx\n", initrd_addr, > initrd_size); Ditto and PRIuGRUB_SIZE. > grub_dprintf ("loader", "Boot arguments: %s\n", linux_args); > grub_dprintf ("loader", "Jumping to Linux...\n"); > @@ -360,7 +360,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)), > if (addr == (grub_addr_t) -1) > goto fail; > > - grub_dprintf ("loader", "Loading initrd at 0x%x, size 0x%x\n", addr, size); > + grub_dprintf ("loader", "Loading initrd at 0x%lx, size 0x%lx\n", addr, size); > Ditto. > if (grub_initrd_load (&initrd_ctx, argv, (void *) addr)) > goto fail;