From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WV2oz-00084Q-BZ for mharc-grub-devel@gnu.org; Tue, 01 Apr 2014 13:50:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV2os-0007uh-Fc for grub-devel@gnu.org; Tue, 01 Apr 2014 13:50:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WV2om-0005AV-EF for grub-devel@gnu.org; Tue, 01 Apr 2014 13:49:54 -0400 Received: from mail-lb0-x22a.google.com ([2a00:1450:4010:c04::22a]:52222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WV2om-0005AJ-6h for grub-devel@gnu.org; Tue, 01 Apr 2014 13:49:48 -0400 Received: by mail-lb0-f170.google.com with SMTP id s7so7370044lbd.1 for ; Tue, 01 Apr 2014 10:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=OVkhtBerbvvBiq/uq2AOrZdPJ/qfVoBMtRmhSiSLGe8=; b=BVLQN16NGKhufTxx8wvyaVTRIn8e7sZn9iJoIxpAHspdkDvjhpTbM1/BqiB4wMzhyT 0YyD+yf/XHZS3g+ckIEty3gPhXtLbh/2jotEXM89dje7SI0EhWUhbZxOvABiJQIRQOVL ZLMMGdJmMeN985t6NhCaaOMDti9WQQbNEJORv9v2tU4P+Gddve/+lT9Y7g4J/jSJip1P pRSliZ/oxQvl6ZG5OOGu+ZU84zVObMMEGXuqeLG3kgrrYuXo1n9rOsW9RM2M0nEOUIaV 5yGKkCqTxoGUdQUSFzVFu+INRhinnxJLbMhcnIa/J2L+pQZ10fUo3fPKHlSwV4YugLov BmGA== X-Received: by 10.152.30.41 with SMTP id p9mr7860286lah.26.1396374586901; Tue, 01 Apr 2014 10:49:46 -0700 (PDT) Received: from opensuse.site (ppp37-190-15-130.pppoe.spdop.ru. [37.190.15.130]) by mx.google.com with ESMTPSA id mk5sm17713050lac.6.2014.04.01.10.49.45 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 01 Apr 2014 10:49:46 -0700 (PDT) Date: Tue, 1 Apr 2014 21:49:45 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: [RFC PATCH 21/23] powerpc64 is not necessarily BigEndian anymore! :) Message-ID: <20140401214945.209b4894@opensuse.site> In-Reply-To: <1393439482-20341-22-git-send-email-linuxram@us.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-22-git-send-email-linuxram@us.ibm.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22a Cc: tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, anton@au1.ibm.com, linuxram@us.ibm.com, tonyb@au1.ibm.com, Anton Blanchard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Apr 2014 17:50:00 -0000 В Wed, 26 Feb 2014 10:31:20 -0800 Ram Pai пишет: > From: Anton Blanchard > > powerpc64 is not necessarily BigEndian anymore! :) > > Signed-off-by: Ram Pai > --- > include/grub/powerpc/types.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/include/grub/powerpc/types.h b/include/grub/powerpc/types.h > index 7a2fc6b..ab138d4 100644 > --- a/include/grub/powerpc/types.h > +++ b/include/grub/powerpc/types.h > @@ -19,7 +19,7 @@ > #ifndef GRUB_TYPES_CPU_HEADER > #define GRUB_TYPES_CPU_HEADER 1 > > -#ifdef __powerpc64le__ > +#ifdef __powerpc64__ > /* The size of void *. */ > #define GRUB_TARGET_SIZEOF_VOID_P 8 > > @@ -33,8 +33,12 @@ > #define GRUB_TARGET_SIZEOF_LONG 4 > #endif > > -/* powerpc is big-endian. */ > -#define GRUB_TARGET_WORDS_BIGENDIAN 1 > +#ifdef __powerpc64le__ > +#undef GRUB_TARGET_WORDS_BIGENDIAN > +#else > +#define GRUB_TARGET_WORDS_BIGENDIAN 1 > +#endif > + For the sake of bisectability this really should be moved earlier; otherwise at least patch "fix parameter to firmware calls" would be wrong. > > > #endif /* ! GRUB_TYPES_CPU_HEADER */