From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WVOZy-0003pY-8X for mharc-grub-devel@gnu.org; Wed, 02 Apr 2014 13:03:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOZp-0003oP-UI for grub-devel@gnu.org; Wed, 02 Apr 2014 13:03:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVOZi-0003XQ-3D for grub-devel@gnu.org; Wed, 02 Apr 2014 13:03:49 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:46792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOZh-0003XM-Vn for grub-devel@gnu.org; Wed, 02 Apr 2014 13:03:42 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Apr 2014 13:03:41 -0400 Received: from d01dlp03.pok.ibm.com (9.56.250.168) by e8.ny.us.ibm.com (192.168.1.108) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 2 Apr 2014 13:03:40 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id EA22FC90043 for ; Wed, 2 Apr 2014 13:03:35 -0400 (EDT) Received: from d01av05.pok.ibm.com (d01av05.pok.ibm.com [9.56.224.195]) by b01cxnp23034.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s32H3dDM8913228 for ; Wed, 2 Apr 2014 17:03:39 GMT Received: from d01av05.pok.ibm.com (localhost [127.0.0.1]) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s32H3dcs014893 for ; Wed, 2 Apr 2014 13:03:39 -0400 Received: from ram.oc3035372033.ibm.com (dyn9050019135.mts.ibm.com [9.50.19.135] (may be forged)) by d01av05.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s32H3aqo014807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 2 Apr 2014 13:03:38 -0400 Date: Wed, 2 Apr 2014 10:03:35 -0700 From: Ram Pai To: Andrey Borzenkov Subject: Re: [RFC PATCH 09/23] Fix warnings when building powerpc linux loader 64bit Message-ID: <20140402170335.GC29218@ram.oc3035372033.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-10-git-send-email-linuxram@us.ibm.com> <20140401212146.0d46eb78@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140401212146.0d46eb78@opensuse.site> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14040217-0320-0000-0000-000002D5F28A X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 32.97.182.138 Cc: The development of GNU GRUB , tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, anton@au1.ibm.com, tonyb@au1.ibm.com, Anton Blanchard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 17:03:57 -0000 On Tue, Apr 01, 2014 at 09:21:46PM +0400, Andrey Borzenkov wrote: > В Wed, 26 Feb 2014 10:31:08 -0800 > Ram Pai пишет: > > > From: Anton Blanchard > > > > Fix warnings when building powerpc linux loader 64bit > > > > Signed-off-by: Ram Pai > > From: Anton Blanchard > > --- > > grub-core/loader/powerpc/ieee1275/linux.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/grub-core/loader/powerpc/ieee1275/linux.c b/grub-core/loader/powerpc/ieee1275/linux.c > > index 4a14f66..3d6a61e 100644 > > --- a/grub-core/loader/powerpc/ieee1275/linux.c > > +++ b/grub-core/loader/powerpc/ieee1275/linux.c > > @@ -141,8 +141,8 @@ grub_linux_boot (void) > > grub_ieee1275_set_property (grub_ieee1275_chosen, "bootargs", linux_args, > > grub_strlen (linux_args) + 1, &actual); > > > > - grub_dprintf ("loader", "Entry point: 0x%x\n", linux_entry); > > - grub_dprintf ("loader", "Initrd at: 0x%x, size 0x%x\n", initrd_addr, > > + grub_dprintf ("loader", "Entry point: 0x%lx\n", linux_entry); > > I guess using PRIxGRUB_ADDR is more consistent - it can now be both 32 and 64 bits. > > > + grub_dprintf ("loader", "Initrd at: 0x%lx, size 0x%lx\n", initrd_addr, > > initrd_size); > > Ditto and PRIuGRUB_SIZE. > > > grub_dprintf ("loader", "Boot arguments: %s\n", linux_args); > > grub_dprintf ("loader", "Jumping to Linux...\n"); > > @@ -360,7 +360,7 @@ grub_cmd_initrd (grub_command_t cmd __attribute__ ((unused)), > > if (addr == (grub_addr_t) -1) > > goto fail; > > > > - grub_dprintf ("loader", "Loading initrd at 0x%x, size 0x%x\n", addr, size); > > + grub_dprintf ("loader", "Loading initrd at 0x%lx, size 0x%lx\n", addr, size); > > > > Ditto. > > > if (grub_initrd_load (&initrd_ctx, argv, (void *) addr)) > > goto fail; ok. will do. RP