From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WVOer-0000c1-Gw for mharc-grub-devel@gnu.org; Wed, 02 Apr 2014 13:09:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOef-0000aL-PB for grub-devel@gnu.org; Wed, 02 Apr 2014 13:08:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVOeW-0005cN-Np for grub-devel@gnu.org; Wed, 02 Apr 2014 13:08:49 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:56867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOeW-0005cJ-Fm for grub-devel@gnu.org; Wed, 02 Apr 2014 13:08:40 -0400 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Apr 2014 11:08:39 -0600 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 2 Apr 2014 11:08:37 -0600 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 601FF19D8036 for ; Wed, 2 Apr 2014 11:08:33 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08025.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s32H8bMV5570856 for ; Wed, 2 Apr 2014 19:08:37 +0200 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s32H8aNe008634 for ; Wed, 2 Apr 2014 11:08:36 -0600 Received: from ram.oc3035372033.ibm.com (dyn9050019135.mts.ibm.com [9.50.19.135] (may be forged)) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s32H8WYd008343 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 2 Apr 2014 11:08:35 -0600 Date: Wed, 2 Apr 2014 10:08:32 -0700 From: Ram Pai To: Andrey Borzenkov Subject: Re: [RFC PATCH 20/23] fix parameter to firmware calls Message-ID: <20140402170832.GE29218@ram.oc3035372033.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-21-git-send-email-linuxram@us.ibm.com> <20140401214535.324d3162@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140401214535.324d3162@opensuse.site> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14040217-0928-0000-0000-000000F1C73E X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 32.97.110.150 Cc: The development of GNU GRUB , anton@au1.ibm.com, tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, tonyb@au1.ibm.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 17:08:59 -0000 On Tue, Apr 01, 2014 at 09:45:35PM +0400, Andrey Borzenkov wrote: > В Wed, 26 Feb 2014 10:31:19 -0800 > Ram Pai пишет: > > > -#define IEEE1275_ADDR(x) (grub_uint32_t)(grub_addr_t)(x) > > - > > +#define IEEE1275_ADDR(x) (grub_uint32_t)grub_cpu_to_be32((grub_addr_t)(x)) > > +#define IEEE1275_VALUE(x) (grub_uint32_t)grub_cpu_to_be32(x) > > Same question - what about sparc64, is it safe to truncate values there? dont know anything about sparc64. Probably not. These macros are used only for the powerpc specific code AFAICT. I will audit and confirm. -- Ram Pai