From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1WVOfO-00010X-NH for mharc-grub-devel@gnu.org; Wed, 02 Apr 2014 13:09:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOfF-0000oy-1n for grub-devel@gnu.org; Wed, 02 Apr 2014 13:09:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVOf7-0005ig-7a for grub-devel@gnu.org; Wed, 02 Apr 2014 13:09:24 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:41740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVOf7-0005iY-00 for grub-devel@gnu.org; Wed, 02 Apr 2014 13:09:17 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 2 Apr 2014 11:09:16 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 2 Apr 2014 11:09:14 -0600 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id A1BAA1FF003D for ; Wed, 2 Apr 2014 11:09:13 -0600 (MDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by b03cxnp08025.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s32H9DB45570964 for ; Wed, 2 Apr 2014 19:09:13 +0200 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id s32HCsOp022058 for ; Wed, 2 Apr 2014 11:12:54 -0600 Received: from ram.oc3035372033.ibm.com (dyn9050019135.mts.ibm.com [9.50.19.135] (may be forged)) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id s32HCoPt021754 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Wed, 2 Apr 2014 11:12:52 -0600 Date: Wed, 2 Apr 2014 10:09:08 -0700 From: Ram Pai To: Andrey Borzenkov Subject: Re: [RFC PATCH 21/23] powerpc64 is not necessarily BigEndian anymore! :) Message-ID: <20140402170908.GF29218@ram.oc3035372033.ibm.com> References: <1393439482-20341-1-git-send-email-linuxram@us.ibm.com> <1393439482-20341-22-git-send-email-linuxram@us.ibm.com> <20140401214945.209b4894@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20140401214945.209b4894@opensuse.site> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14040217-8236-0000-0000-0000013DA7C9 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 32.97.110.149 Cc: The development of GNU GRUB , tlfalcon@linux.vnet.ibm.com, tbberry@us.ibm.com, anton@au1.ibm.com, tonyb@au1.ibm.com, Anton Blanchard X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Apr 2014 17:09:33 -0000 On Tue, Apr 01, 2014 at 09:49:45PM +0400, Andrey Borzenkov wrote: > В Wed, 26 Feb 2014 10:31:20 -0800 > Ram Pai пишет: > > > From: Anton Blanchard > > > > powerpc64 is not necessarily BigEndian anymore! :) > > > > Signed-off-by: Ram Pai > > --- > > include/grub/powerpc/types.h | 10 +++++++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/include/grub/powerpc/types.h b/include/grub/powerpc/types.h > > index 7a2fc6b..ab138d4 100644 > > --- a/include/grub/powerpc/types.h > > +++ b/include/grub/powerpc/types.h > > @@ -19,7 +19,7 @@ > > #ifndef GRUB_TYPES_CPU_HEADER > > #define GRUB_TYPES_CPU_HEADER 1 > > > > -#ifdef __powerpc64le__ > > +#ifdef __powerpc64__ > > /* The size of void *. */ > > #define GRUB_TARGET_SIZEOF_VOID_P 8 > > > > @@ -33,8 +33,12 @@ > > #define GRUB_TARGET_SIZEOF_LONG 4 > > #endif > > > > -/* powerpc is big-endian. */ > > -#define GRUB_TARGET_WORDS_BIGENDIAN 1 > > +#ifdef __powerpc64le__ > > +#undef GRUB_TARGET_WORDS_BIGENDIAN > > +#else > > +#define GRUB_TARGET_WORDS_BIGENDIAN 1 > > +#endif > > + > > For the sake of bisectability this really should be moved earlier; > otherwise at least patch "fix parameter to firmware calls" would > be wrong. Yes. will do. Thanks for your time and valuable comments! RP