From: Andrey Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: phcoder@gmail.com
Subject: Re: [PATCH] fix PXE transmit failure if P_UNKNOWN is not supported
Date: Sat, 26 Jul 2014 07:55:03 +0400 [thread overview]
Message-ID: <20140726075503.38bd2db7@opensuse.site> (raw)
In-Reply-To: <53D2CE5A.2040102@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
В Fri, 25 Jul 2014 23:38:34 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> On 25.07.2014 17:53, Andrey Borzenkov wrote:
> > Some PXE stacks do not support P_UNKNOWN in UNDI TRANSMIT; nothing is
> > sent at all. So strip Ethernet header for known frame types and let PXE
> > stack add it.
> >
> If I'm reading this patch correctly it discards several fields of the
> packet and i.a. kills vlan fields.
No, it does not. It discards Ethernet headers only when packet type is
IP or ARP. VLAN packet will have different type and will be passed
through as happens currently.
> Such low in the stack it should
> replace the header only in the case of perfect match. It will be perfect
> match in 99% of configs but we shouldn0t break configs on unaffected
> machines.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-07-26 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 15:53 [PATCH] fix PXE transmit failure if P_UNKNOWN is not supported Andrey Borzenkov
2014-07-25 21:38 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-07-26 3:55 ` Andrey Borzenkov [this message]
2014-09-27 6:26 ` Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140726075503.38bd2db7@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=phcoder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).