grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: phcoder@gmail.com
Subject: Re: HOST_* flags are not used by gnulib
Date: Mon, 28 Jul 2014 06:52:59 +0400	[thread overview]
Message-ID: <20140728065259.1ce3c393@opensuse.site> (raw)
In-Reply-To: <53CF6732.4030500@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

В Wed, 23 Jul 2014 09:41:38 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 03.04.2014 20:01, Andrey Borzenkov wrote:
> > I noticed that host flags are not propagated to gnulib. This does not
> > feel right; in particular I noticed it because attempt to enable
> > debugging for host tools (HOST_CFLAGS=-g) did not work for gnulib files.
> > 
> It should be just CFLAGS (refer to INSTALL)

The problem is that CFLAGS leak into target. Default compilation
command used by automake is

COMPILE = $(CC) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) \
        $(CPPFLAGS) $(AM_CFLAGS) $(CFLAGS)

And any initial CFLAGS setting is passed through to all generated
Makefiles. 

So instructions in INSTALL are, unfortunately, wrong - CFLAGS cannot be
safely used to initialize host environment.

> > Is it intentional?
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > Grub-devel@gnu.org
> > https://lists.gnu.org/mailman/listinfo/grub-devel
> > 
> 
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      parent reply	other threads:[~2014-07-28  2:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03 18:01 HOST_* flags are not used by gnulib Andrey Borzenkov
2014-07-23  7:41 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-07-27 18:06   ` Mike Gilbert
2014-07-27 18:10     ` Vladimir 'phcoder' Serbinenko
2014-07-27 18:24       ` Mike Gilbert
2014-07-27 18:39         ` Andrey Borzenkov
2014-07-27 18:42           ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-07-27 18:48             ` Andrey Borzenkov
2014-07-27 18:55               ` Mike Gilbert
2014-07-28  2:52   ` Andrey Borzenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140728065259.1ce3c393@opensuse.site \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    --cc=phcoder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).