From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XEJeA-0005vL-RO for mharc-grub-devel@gnu.org; Mon, 04 Aug 2014 10:53:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEJe5-0005v0-9N for grub-devel@gnu.org; Mon, 04 Aug 2014 10:53:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEJe0-0007bg-Jq for grub-devel@gnu.org; Mon, 04 Aug 2014 10:53:53 -0400 Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]:58521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEJe0-0007bB-BQ for grub-devel@gnu.org; Mon, 04 Aug 2014 10:53:48 -0400 Received: by mail-la0-f51.google.com with SMTP id pn19so5378264lab.24 for ; Mon, 04 Aug 2014 07:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=TzXKFexyivGfatPmMsrDfn9hcrGLQTeiV1vMSWhfqZ8=; b=ZIZmoFWIuPgJvApI4CSQsNPx5Ty4iDuADfJY4CpHUr3zBczWn4bCz/XKbOufEkq3sm cdmwGUb8gXi6M6ULilKf/lZ6wwaE4dDaxAOVD+jDUm3ATHmwM7m5oYBEPN7xh1b9d2cU yuAV83+Rn5/on5xkKwbXgF/3DlsNrnXfjCvWMNFxMEhM1p/HjH9UFOLgnF7S6u24k0Km OS6p9CWPHJobfgrg/g1qEMBwXBf352v8OcuITDjK85g74OL9SWHWrC/HWJgxdPXPed8y jDOLoppHLeQ/ioAu8/H3VsBX/LRa7T5SuPCmF2xvmosKpl4Vn6FLqFcixkMBSeWeQtGb nwlA== X-Received: by 10.112.119.142 with SMTP id ku14mr22964054lbb.34.1407164027102; Mon, 04 Aug 2014 07:53:47 -0700 (PDT) Received: from opensuse.site (ppp94-29-76-101.pppoe.spdop.ru. [94.29.76.101]) by mx.google.com with ESMTPSA id qh2sm27964214lbc.48.2014.08.04.07.53.46 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 04 Aug 2014 07:53:46 -0700 (PDT) Date: Mon, 4 Aug 2014 18:53:46 +0400 From: Andrey Borzenkov To: The development of GNU GRUB Subject: Re: [RFC PATCH] configure check for ld's --no-relax flag Message-ID: <20140804185346.22e2f581@opensuse.site> In-Reply-To: <53DF2C02.4030607@oracle.com> References: <1406895356-28090-1-git-send-email-stanislav.kholmanskikh@oracle.com> <20140801193559.61fe4363@opensuse.site> <53DBB4D4.3090508@gmail.com> <53DF2C02.4030607@oracle.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.22; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::233 Cc: stanislav.kholmanskikh@oracle.com X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Aug 2014 14:53:57 -0000 =D0=92 Mon, 04 Aug 2014 10:45:22 +0400 Stanislav Kholmanskikh =D0=BF=D0=B8=D1= =88=D0=B5=D1=82: > Hi! >=20 > On 08/01/2014 07:40 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote: > > On 01.08.2014 17:35, Andrey Borzenkov wrote: > >> =D0=92 Fri, 1 Aug 2014 16:15:56 +0400 > >> Stanislav Kholmanskikh =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: > >> > >>> Early versions of binutils doesn't support --no-relax flag, so > >>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building > >>> with such versions. > >>> > >>> Signed-off-by: Stanislav Kholmanskikh > >>> --- > >>> conf/Makefile.common | 8 ++++++++ > >>> configure.ac | 10 ++++++++++ > >>> 2 files changed, 18 insertions(+), 0 deletions(-) > >>> > >>> diff --git a/conf/Makefile.common b/conf/Makefile.common > >>> index e4c301f..5bda66f 100644 > >>> --- a/conf/Makefile.common > >>> +++ b/conf/Makefile.common > >>> @@ -8,11 +8,19 @@ unexport LC_ALL > >>> # Platform specific options > >>> if COND_sparc64_ieee1275 > >>> CFLAGS_PLATFORM +=3D -mno-app-regs > >>> +if COND_LD_SUPPORTS_NO_RELAX > >>> LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -Wl,--no-relax > >>> +else > >>> + LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -mno-relax > >>> +endif > >> > >> TBO I think commit should simply be reverted. "Uniformity" is rather > >> poor excuse for breaking existing systems. > >> > > This commit is needed for clang to compile for sparc64. Given that > > sparc64 clang still doesn't really work I'm ok with reverting, at least > > for now. >=20 > But, it this case, maybe it would be better to consider=20 > reviewing/applying this patch? Just to not return to this issue after=20 > some time? >=20 > Andrey, Vladimir, what do you think? >=20 Yes, commit message was pretty confusing. This leaves the question, whether combination of clang and binutils that do not support -Wl,--no-relax exists though :) Otherwise I agree, we should use this patch.