From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Takashi Iwai <tiwai@suse.de>, Jeff Mahoney <jeffm@suse.com>
Subject: Re: [PATCH] Fix incorrect address reference in btrfs
Date: Mon, 8 Sep 2014 11:34:09 +0100 [thread overview]
Message-ID: <20140908103409.GA9570@riva.ucam.org> (raw)
In-Reply-To: <20140814105000.GA26305@linux-dsax.tai.apac.novell.com>
On Thu, Aug 14, 2014 at 06:50:00PM +0800, Michael Chang wrote:
> On Thu, Aug 14, 2014 at 06:17:45PM +0800, Michael Chang wrote:
> > We encountered a weird random kernel initrd unpacking error on btrfs
> > and finally found it was caused by incorrect address reference in range
> > check for type GRUB_BTRFS_EXTENT_REGULAR and the entire result is
> > unpredictable.
> >
> > This is a quick fix to make the address reference to the
> > grub_btrfs_entent_data structure correctly, not the pointer variable
> > to it.
> >
> > Any suggestions to this patch is welcome.
Looks good to me, thanks. Added a ChangeLog entry and pushed to master.
--
Colin Watson [cjwatson@ubuntu.com]
prev parent reply other threads:[~2014-09-08 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-14 10:17 [PATCH] Fix incorrect address reference in btrfs Michael Chang
2014-08-14 10:50 ` Michael Chang
2014-09-08 10:34 ` Colin Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908103409.GA9570@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
--cc=jeffm@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).