From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XQwHI-0008J6-22 for mharc-grub-devel@gnu.org; Mon, 08 Sep 2014 06:34:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQwHE-0008IM-Ic for grub-devel@gnu.org; Mon, 08 Sep 2014 06:34:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQwH9-0001dH-2Q for grub-devel@gnu.org; Mon, 08 Sep 2014 06:34:28 -0400 Received: from b.painless.aa.net.uk ([2001:8b0:0:30::51bb:1e34]:37865 helo=b.b.painless.aa.net.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQwH8-0001cx-Ti for grub-devel@gnu.org; Mon, 08 Sep 2014 06:34:23 -0400 Received: from 3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.4.1.b.e.2.f.f.b.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:bff2:eb14::3] helo=riva.pelham.vpn.ucam.org) by b.painless.aa.net.uk with esmtps (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1XQwGy-0002gK-04; Mon, 08 Sep 2014 11:34:19 +0100 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XQwGw-0004PS-Qc; Mon, 08 Sep 2014 11:34:10 +0100 Date: Mon, 8 Sep 2014 11:34:09 +0100 From: Colin Watson To: The development of GNU GRUB Subject: Re: [PATCH] Fix incorrect address reference in btrfs Message-ID: <20140908103409.GA9570@riva.ucam.org> References: <1408011465-25794-1-git-send-email-mchang@suse.com> <20140814105000.GA26305@linux-dsax.tai.apac.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140814105000.GA26305@linux-dsax.tai.apac.novell.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:0:30::51bb:1e34 Cc: Takashi Iwai , Jeff Mahoney X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2014 10:34:30 -0000 On Thu, Aug 14, 2014 at 06:50:00PM +0800, Michael Chang wrote: > On Thu, Aug 14, 2014 at 06:17:45PM +0800, Michael Chang wrote: > > We encountered a weird random kernel initrd unpacking error on btrfs > > and finally found it was caused by incorrect address reference in range > > check for type GRUB_BTRFS_EXTENT_REGULAR and the entire result is > > unpredictable. > > > > This is a quick fix to make the address reference to the > > grub_btrfs_entent_data structure correctly, not the pointer variable > > to it. > > > > Any suggestions to this patch is welcome. Looks good to me, thanks. Added a ChangeLog entry and pushed to master. -- Colin Watson [cjwatson@ubuntu.com]