From: Andrei Borzenkov <arvidjaar@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH 0/2] Allow editenv to follow symlinks to find/make grubenv
Date: Sat, 13 Sep 2014 20:43:10 +0400 [thread overview]
Message-ID: <20140913204310.1ee1c04f@opensuse.site> (raw)
In-Reply-To: <1409845015-16778-1-git-send-email-pjones@redhat.com>
В Thu, 4 Sep 2014 11:36:53 -0400
Peter Jones <pjones@redhat.com> пишет:
> Hi,
> This is a patch series to allow grub-editenv and related utilities to
> follow symbolic links when finding its config file. This allows, for
> example, the ability to have two builds of grub for different platforms
> that have different prefixes set, but still use the same userland grub
> utilities.
>
> For example, in our EFI builds we'll typically have prefix set as
> /EFI/fedora (on the EFI System Partition), but when you install on a BIOS
> machine it'll be /boot/grub2 (which may or may not be its own mountpoint.)
>
This sounds more like misusing of ${prefix}. ${prefix} is supposed to
be target independent. Any target-dependent file is going into
${prefix}/${grub_cpu}-${grub_platform}. That allows to use the
same /boot/grub for any platform (and possibly make run-time
platform-specific decision).
> With this patch, on EFI machines we can make /boot/grub2/grubenv a symlink
> to /boot/efi/EFI/fedora/grubenv , and the same copy of grub-set-default will
> work on both kinds of systems.
>
> Note: I'm not entirely sure I've done the gnulib parts of the first patch
> the preferred way, but they do appear to be functional. I wound up using
> "gnulib-tool --import --dir=. --lib=libgnu --source-base=grub-core/gnulib --m4-base=m4 --doc-base=doc --tests-base=tests --aux-dir=build-aux --no-conditional-dependencies --no-libtool --macro-prefix=gl --no-vc-files argp error fnmatch getdelim getline gettext progname readlink regex"
> and then only adding in the parts directly related to readlink().
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
prev parent reply other threads:[~2014-09-13 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 15:36 [PATCH 0/2] Allow editenv to follow symlinks to find/make grubenv Peter Jones
2014-09-04 15:36 ` [PATCH 1/2] Add grub_util_readlink() Peter Jones
2014-09-04 15:36 ` [PATCH 2/2] Make editenv chase symlinks including those across devices Peter Jones
2014-09-21 16:15 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-09-13 16:43 ` Andrei Borzenkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140913204310.1ee1c04f@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).