From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XSqQ1-0000Zc-L4 for mharc-grub-devel@gnu.org; Sat, 13 Sep 2014 12:43:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSqPv-0000ZQ-4F for grub-devel@gnu.org; Sat, 13 Sep 2014 12:43:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSqPp-0007wY-Hm for grub-devel@gnu.org; Sat, 13 Sep 2014 12:43:19 -0400 Received: from mail-la0-x22e.google.com ([2a00:1450:4010:c03::22e]:49800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSqPp-0007wQ-AJ for grub-devel@gnu.org; Sat, 13 Sep 2014 12:43:13 -0400 Received: by mail-la0-f46.google.com with SMTP id el20so2589323lab.19 for ; Sat, 13 Sep 2014 09:43:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=LimmqKD+1NdqeOCMfAtPS7c36YlRRbO7kuY5ztJmmcs=; b=KlpkB+w4J8pbWm3J4LFHGi8DhYpsXjYNFvDMXV+rzdLken3jnrj5kPt2x1nWeYNJk6 VyyqpAZgFE0ZXYh/f2li58dSNHLVAx8MRXkNnLi3eavw+Zn7Dlg3VRKkRdC4MfBpVPRE vmu8VyJUxlnyQeQ6BHDuQfu6hp5mAzHwhpdLP0hp2SJUsmKJPJ1BfKcdNMTkJQXCndl1 WU7BScofMn2etZjNkGXMXL3YN/JcX+aXHzNxaw+7ABZh7x2jriv6I3yKVtaMRVIN8HHh aXHXDk0KmeidqKemOLV/vLB6qi2lf8UJ5hc/120H7w1s63ycsbuDM2+7iqsSveHbhbsA sgOg== X-Received: by 10.152.116.80 with SMTP id ju16mr16894457lab.73.1410626592127; Sat, 13 Sep 2014 09:43:12 -0700 (PDT) Received: from opensuse.site ([37.190.69.201]) by mx.google.com with ESMTPSA id a9sm2355498laa.3.2014.09.13.09.43.10 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 13 Sep 2014 09:43:11 -0700 (PDT) Date: Sat, 13 Sep 2014 20:43:10 +0400 From: Andrei Borzenkov To: The development of GNU GRUB Subject: Re: [PATCH 0/2] Allow editenv to follow symlinks to find/make grubenv Message-ID: <20140913204310.1ee1c04f@opensuse.site> In-Reply-To: <1409845015-16778-1-git-send-email-pjones@redhat.com> References: <1409845015-16778-1-git-send-email-pjones@redhat.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.23; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22e X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Sep 2014 16:43:24 -0000 =D0=92 Thu, 4 Sep 2014 11:36:53 -0400 Peter Jones =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > Hi, > This is a patch series to allow grub-editenv and related utilities to > follow symbolic links when finding its config file. This allows, for > example, the ability to have two builds of grub for different platforms > that have different prefixes set, but still use the same userland grub > utilities. >=20 > For example, in our EFI builds we'll typically have prefix set as > /EFI/fedora (on the EFI System Partition), but when you install on a BIOS > machine it'll be /boot/grub2 (which may or may not be its own mountpoint.) >=20 This sounds more like misusing of ${prefix}. ${prefix} is supposed to be target independent. Any target-dependent file is going into ${prefix}/${grub_cpu}-${grub_platform}. That allows to use the same /boot/grub for any platform (and possibly make run-time platform-specific decision). > With this patch, on EFI machines we can make /boot/grub2/grubenv a symlink > to /boot/efi/EFI/fedora/grubenv , and the same copy of grub-set-default w= ill > work on both kinds of systems. >=20 > Note: I'm not entirely sure I've done the gnulib parts of the first patch > the preferred way, but they do appear to be functional. I wound up using > "gnulib-tool --import --dir=3D. --lib=3Dlibgnu --source-base=3Dgrub-core/= gnulib --m4-base=3Dm4 --doc-base=3Ddoc --tests-base=3Dtests --aux-dir=3Dbui= ld-aux --no-conditional-dependencies --no-libtool --macro-prefix=3Dgl --no-= vc-files argp error fnmatch getdelim getline gettext progname readlink rege= x" > and then only adding in the parts directly related to readlink(). >=20 >=20 > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel