From: Colin Watson <cjwatson@ubuntu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Support grub-emu on x32 (ILP32 but with x86-64 instruction set)
Date: Sun, 14 Sep 2014 21:02:44 +0100 [thread overview]
Message-ID: <20140914200244.GA21345@riva.ucam.org> (raw)
In-Reply-To: <20140913192143.16bb3551@opensuse.site>
On Sat, Sep 13, 2014 at 07:21:43PM +0400, Andrei Borzenkov wrote:
> > * configure.ac: Remove -m64 from checks for -mcmodel=large and
> > -mno-red-zone. These are always either unnecessary (x86_64-emu) or
> > already in TARGET_CFLAGS at this point, and they produce incorrect
> > results when building for x32.
>
> This was added to match what grub-core/Makefile.am actually uses. So
> basically either Makefile.am needs fixing as well or your patch does
> not fix the actual problem - meaning efiemu64.o will fail to compile.
That's fine. My change was not in the efiemu test, but in some similar
tests further down whose output is used to adjust TARGET_CFLAGS. It
would be incorrect to sync these tests with the manual rules for efiemu.
--
Colin Watson [cjwatson@ubuntu.com]
prev parent reply other threads:[~2014-09-14 20:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 15:21 Support grub-emu on x32 (ILP32 but with x86-64 instruction set) Andrei Borzenkov
2014-09-14 20:02 ` Colin Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140914200244.GA21345@riva.ucam.org \
--to=cjwatson@ubuntu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).