From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XTG0h-0005hZ-IO for mharc-grub-devel@gnu.org; Sun, 14 Sep 2014 16:02:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTG0f-0005es-EF for grub-devel@gnu.org; Sun, 14 Sep 2014 16:02:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XTG0d-0000O7-Hp for grub-devel@gnu.org; Sun, 14 Sep 2014 16:02:57 -0400 Received: from b.painless.aa.net.uk ([2001:8b0:0:30::51bb:1e34]:50184 helo=b.b.painless.aa.net.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XTG0d-0000Nv-Ck for grub-devel@gnu.org; Sun, 14 Sep 2014 16:02:55 -0400 Received: from 3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.4.1.b.e.2.f.f.b.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:bff2:eb14::3] helo=riva.pelham.vpn.ucam.org) by b.painless.aa.net.uk with esmtps (TLSv1:AES128-SHA:128) (Exim 4.72) (envelope-from ) id 1XTG0U-0001O2-MC for grub-devel@gnu.org; Sun, 14 Sep 2014 21:02:52 +0100 Received: from ns1.pelham.vpn.ucam.org ([172.20.153.2] helo=riva.ucam.org) by riva.pelham.vpn.ucam.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XTG0T-0005ZA-Qz for grub-devel@gnu.org; Sun, 14 Sep 2014 21:02:45 +0100 Date: Sun, 14 Sep 2014 21:02:44 +0100 From: Colin Watson To: The development of GNU GRUB Subject: Re: Support grub-emu on x32 (ILP32 but with x86-64 instruction set) Message-ID: <20140914200244.GA21345@riva.ucam.org> References: <20140913192143.16bb3551@opensuse.site> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140913192143.16bb3551@opensuse.site> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:0:30::51bb:1e34 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Sep 2014 20:02:58 -0000 On Sat, Sep 13, 2014 at 07:21:43PM +0400, Andrei Borzenkov wrote: > > * configure.ac: Remove -m64 from checks for -mcmodel=large and > > -mno-red-zone. These are always either unnecessary (x86_64-emu) or > > already in TARGET_CFLAGS at this point, and they produce incorrect > > results when building for x32. > > This was added to match what grub-core/Makefile.am actually uses. So > basically either Makefile.am needs fixing as well or your patch does > not fix the actual problem - meaning efiemu64.o will fail to compile. That's fine. My change was not in the efiemu test, but in some similar tests further down whose output is used to adjust TARGET_CFLAGS. It would be incorrect to sync these tests with the manual rules for efiemu. -- Colin Watson [cjwatson@ubuntu.com]