* Re: Support grub-emu on x32 (ILP32 but with x86-64 instruction set)
@ 2014-09-13 15:21 Andrei Borzenkov
2014-09-14 20:02 ` Colin Watson
0 siblings, 1 reply; 2+ messages in thread
From: Andrei Borzenkov @ 2014-09-13 15:21 UTC (permalink / raw)
To: cjwatson, grub-devel
> * configure.ac: Remove -m64 from checks for -mcmodel=large and
> -mno-red-zone. These are always either unnecessary (x86_64-emu) or
> already in TARGET_CFLAGS at this point, and they produce incorrect
> results when building for x32.
This was added to match what grub-core/Makefile.am actually uses. So
basically either Makefile.am needs fixing as well or your patch does
not fix the actual problem - meaning efiemu64.o will fail to compile.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Support grub-emu on x32 (ILP32 but with x86-64 instruction set)
2014-09-13 15:21 Support grub-emu on x32 (ILP32 but with x86-64 instruction set) Andrei Borzenkov
@ 2014-09-14 20:02 ` Colin Watson
0 siblings, 0 replies; 2+ messages in thread
From: Colin Watson @ 2014-09-14 20:02 UTC (permalink / raw)
To: The development of GNU GRUB
On Sat, Sep 13, 2014 at 07:21:43PM +0400, Andrei Borzenkov wrote:
> > * configure.ac: Remove -m64 from checks for -mcmodel=large and
> > -mno-red-zone. These are always either unnecessary (x86_64-emu) or
> > already in TARGET_CFLAGS at this point, and they produce incorrect
> > results when building for x32.
>
> This was added to match what grub-core/Makefile.am actually uses. So
> basically either Makefile.am needs fixing as well or your patch does
> not fix the actual problem - meaning efiemu64.o will fail to compile.
That's fine. My change was not in the efiemu test, but in some similar
tests further down whose output is used to adjust TARGET_CFLAGS. It
would be incorrect to sync these tests with the manual rules for efiemu.
--
Colin Watson [cjwatson@ubuntu.com]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-14 20:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-13 15:21 Support grub-emu on x32 (ILP32 but with x86-64 instruction set) Andrei Borzenkov
2014-09-14 20:02 ` Colin Watson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).