Re: [RFC PATCH 1/3] Add powerpc little-endian (ppc64le) flags

[Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 4219 bytes --]

Thu, Aug 28, 2014 at 04:56:03PM -0300, Paulo Flabiano Smorigo wrote:
> libgcc dependency was removed *just* for this target because
> the distros that use ppc64el doesn't have 32-bit support on it.
> 
> * configure.ac: Add targets for powerpc64el and skip libgcc.
> * Makefile.am: Likewise.
> ---
>  configure.ac          | 17 +++++++++++++++--
>  grub-core/Makefile.am |  2 ++
>  2 files changed, 17 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 8888c2f..1364c8b 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -119,6 +119,7 @@ if test "x$with_platform" = x; then
>      x86_64-*) platform=pc ;;
>      powerpc-*) platform=ieee1275 ;;
>      powerpc64-*) platform=ieee1275 ;;
> +    powerpc64le-*) platform=ieee1275 ;;
>      sparc64-*) platform=ieee1275 ;;
>      mipsel-*) platform=loongson ;;
>      mips-*) platform=arc ;;
> @@ -137,6 +138,7 @@ case "$target_cpu"-"$platform" in
>    x86_64-xen) ;;
>    x86_64-*) target_cpu=i386 ;;
>    powerpc64-ieee1275) target_cpu=powerpc ;;
> +  powerpc64le-ieee1275) target_cpu=powerpc ;;
>  esac
> 
>  # Check if the platform is supported, make final adjustments.
> @@ -581,6 +583,13 @@ if test "x$target_cpu" = xi386 && test "x$platform" != xemu; then
>    TARGET_CFLAGS="$TARGET_CFLAGS -march=i386"
>  fi
> 
> +if test x$target_cpu = xpowerpc && test x$ac_cv_c_bigendian = xno; then
> +	LD_FORCE_LE=1
> +	TARGET_CFLAGS="$TARGET_CFLAGS -mbig-endian -DNO_LIBGCC=1"
> +	TARGET_CCASFLAGS="$TARGET_CCASFLAGS -mbig-endian"
> +	TARGET_LDFLAGS="$TARGET_LDFLAGS -static -mbig-endian"
> +fi
> +
>  if test "x$target_m32" = x1; then
>    # Force 32-bit mode.
>    TARGET_CFLAGS="$TARGET_CFLAGS -m32"
> @@ -1024,7 +1033,8 @@ else
>  CFLAGS="$TARGET_CFLAGS -nostdlib -Wno-error"
>  fi
>  CPPFLAGS="$TARGET_CPPFLAGS"
> -if test x$target_cpu = xi386 || test x$target_cpu = xx86_64 || test "x$grub_cv_cc_target_clang" = xyes ; then
> +if test x$target_cpu = xi386 || test x$target_cpu = xx86_64 || test "x$grub_cv_cc_target_clang" = xyes \
> +	|| ( test x$target_cpu = xpowerpc && test x$ac_cv_c_bigendian = xno ); then
>  TARGET_LIBGCC=
>  else
>  TARGET_LIBGCC=-lgcc
> @@ -1608,7 +1618,9 @@ if test x"$enable_werror" != xno ; then
>    HOST_CFLAGS="$HOST_CFLAGS -Werror"
>  fi
> 
> -if test "x$grub_cv_cc_target_clang" = xno; then
> +# if not clang or power LE, use static libgcc
> +if test "x$grub_cv_cc_target_clang" = xno \
> +   || ! ( test x$target_cpu = xpowerpc && test x$ac_cv_c_bigendian = xno ); then
>     TARGET_LDFLAGS_STATIC_LIBGCC="-static-libgcc"
>  else
>     TARGET_LDFLAGS_STATIC_LIBGCC=
> @@ -1671,6 +1683,7 @@ AM_CONDITIONAL([COND_mips_arc], [test "(" x$target_cpu = xmips -o x$target_cpu =
>  AM_CONDITIONAL([COND_sparc64_ieee1275], [test x$target_cpu = xsparc64 -a x$platform = xieee1275])
>  AM_CONDITIONAL([COND_sparc64_emu], [test x$target_cpu = xsparc64 -a x$platform = xemu])
>  AM_CONDITIONAL([COND_powerpc_ieee1275], [test x$target_cpu = xpowerpc -a x$platform = xieee1275])
> +AM_CONDITIONAL([COND_powerpc_le], [test x$target_cpu = xpowerpc -a x$ac_cv_c_bigendian = xno])
>  AM_CONDITIONAL([COND_mips], [test x$target_cpu = xmips -o x$target_cpu = xmipsel])
>  AM_CONDITIONAL([COND_mipsel], [test x$target_cpu = xmipsel])
>  AM_CONDITIONAL([COND_mipseb], [test x$target_cpu = xmips])
> diff --git a/grub-core/Makefile.am b/grub-core/Makefile.am
> index 5c087c8..cb7fd9f 100644
> --- a/grub-core/Makefile.am
> +++ b/grub-core/Makefile.am
> @@ -84,8 +84,10 @@ KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/time.h
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/mm_private.h
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/net.h
>  if !COND_clang
> +if !COND_powerpc_le
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/libgcc.h
>  endif
> +endif
>  KERNEL_HEADER_FILES += $(top_srcdir)/include/grub/memory.h
> 
>  if COND_i386_pc
> -- 
> 1.8.1.4
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
> 

I just moved some part of this patch to the second one. Now this patch
only add the target and all libgcc stuff is in the second one.

-- 
Paulo Flabiano Smorigo
IBM Linux Technology Center

[-- Attachment #2: 0001-Add-powerpc-little-endian-ppc64le-flags.patch --]
[-- Type: text/plain, Size: 1530 bytes --]

From 7a2e287e6ed00476c6760797541c3aff49dbeb40 Mon Sep 17 00:00:00 2001
From: Paulo Flabiano Smorigo <pfsmorigo@linux.vnet.ibm.com>
Date: Wed, 17 Sep 2014 14:42:40 -0300
Subject: [PATCH 1/2] Add powerpc little-endian (ppc64le) flags

* configure.ac: Add target for ppc64le (ppc64el).
---
 configure.ac | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/configure.ac b/configure.ac
index 8662bac..25193de 100644
--- a/configure.ac
+++ b/configure.ac
@@ -119,6 +119,7 @@ if test "x$with_platform" = x; then
     x86_64-*) platform=pc ;;
     powerpc-*) platform=ieee1275 ;;
     powerpc64-*) platform=ieee1275 ;;
+    powerpc64le-*) platform=ieee1275 ;;
     sparc64-*) platform=ieee1275 ;;
     mipsel-*) platform=loongson ;;
     mips-*) platform=arc ;;
@@ -137,6 +138,7 @@ case "$target_cpu"-"$platform" in
   x86_64-xen) ;;
   x86_64-*) target_cpu=i386 ;;
   powerpc64-ieee1275) target_cpu=powerpc ;;
+  powerpc64le-ieee1275) target_cpu=powerpc ;;
 esac
 
 # Check if the platform is supported, make final adjustments.
@@ -581,6 +583,13 @@ if test "x$target_cpu" = xi386 && test "x$platform" != xemu; then
   TARGET_CFLAGS="$TARGET_CFLAGS -march=i386"
 fi
 
+if test x$target_cpu = xpowerpc && test x$ac_cv_c_bigendian = xno; then
+	#LD_FORCE_LE=1
+	TARGET_CFLAGS="$TARGET_CFLAGS -mbig-endian"
+	TARGET_CCASFLAGS="$TARGET_CCASFLAGS -mbig-endian"
+	TARGET_LDFLAGS="$TARGET_LDFLAGS -static -mbig-endian"
+fi
+
 if test "x$target_m32" = x1; then
   # Force 32-bit mode.
   TARGET_CFLAGS="$TARGET_CFLAGS -m32"
-- 
1.8.4.2