From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XVlHd-0005O3-R3 for mharc-grub-devel@gnu.org; Sun, 21 Sep 2014 13:50:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVlHY-0005Nd-5z for grub-devel@gnu.org; Sun, 21 Sep 2014 13:50:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XVlHT-0002Lj-Lk for grub-devel@gnu.org; Sun, 21 Sep 2014 13:50:44 -0400 Received: from mail-la0-x231.google.com ([2a00:1450:4010:c03::231]:37554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XVlHT-0002LQ-7r for grub-devel@gnu.org; Sun, 21 Sep 2014 13:50:39 -0400 Received: by mail-la0-f49.google.com with SMTP id pn19so5479150lab.22 for ; Sun, 21 Sep 2014 10:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:in-reply-to:references:mime-version :content-type; bh=73wPFRM8FBnV3VDs488ZhQJLHu9opJiaUv0ZUpT4QdM=; b=nddmjH9kHH1lh3/Ideey0LvLeK1karlCPJjeerr19vZLAc0S8hCcfsNpNcSsK9CA09 uLZWmUVA+0zjsuP7D195LCTwz4oX8EPxWt9tmnQieVpOw6SByyYdHwfuhLvl01/hsRB5 5BBsyZ/qLWjY0d4f26W0pSiGQRhnotVJ0tw7cTX5wk6NDeL4CTm0vUviNbTgNd7WIzDS jHJzprkERQVRHjn9zmF+smP115sgbfogoSlBNEQcxXDIAEfQMgAsLLsMAGK7m4/udvQV Tp0L2yN7srCD5ewP1UcR2JxyvTMqbUT2mnk0nJD3jY9/owSWKzUUcrskG3VRsWeO8pJX WW1Q== X-Received: by 10.112.13.232 with SMTP id k8mr19051274lbc.81.1411321832985; Sun, 21 Sep 2014 10:50:32 -0700 (PDT) Received: from opensuse.site (ppp94-29-94-89.pppoe.spdop.ru. [94.29.94.89]) by mx.google.com with ESMTPSA id ll12sm2879440lac.45.2014.09.21.10.50.31 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 21 Sep 2014 10:50:32 -0700 (PDT) Date: Sun, 21 Sep 2014 21:50:30 +0400 From: Andrei Borzenkov To: The development of GNU GRUB Subject: Re: [RFC PATCH] configure check for ld's --no-relax flag Message-ID: <20140921215030.1af8c476@opensuse.site> In-Reply-To: <541F04CC.3040509@gmail.com> References: <1406895356-28090-1-git-send-email-stanislav.kholmanskikh@oracle.com> <20140801193559.61fe4363@opensuse.site> <53DBB4D4.3090508@gmail.com> <53DF2C02.4030607@oracle.com> <20140804185346.22e2f581@opensuse.site> <541F04CC.3040509@gmail.com> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.23; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/5CRPo4Ks8ElzQg=Dh9PZ=yq"; protocol="application/pgp-signature" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::231 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2014 17:50:48 -0000 --Sig_/5CRPo4Ks8ElzQg=Dh9PZ=yq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable =D0=92 Sun, 21 Sep 2014 19:03:08 +0200 Vladimir '=CF=86-coder/phcoder' Serbinenko =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > On 04.08.2014 16:53, Andrey Borzenkov wrote: > > =D0=92 Mon, 04 Aug 2014 10:45:22 +0400 > > Stanislav Kholmanskikh =D0=BF=D0=B8= =D1=88=D0=B5=D1=82: > >=20 > >> Hi! > >> > >> On 08/01/2014 07:40 PM, Vladimir '=CF=86-coder/phcoder' Serbinenko wro= te: > >>> On 01.08.2014 17:35, Andrey Borzenkov wrote: > >>>> =D0=92 Fri, 1 Aug 2014 16:15:56 +0400 > >>>> Stanislav Kholmanskikh =D0=BF=D0= =B8=D1=88=D0=B5=D1=82: > >>>> > >>>>> Early versions of binutils doesn't support --no-relax flag, so > >>>>> commit 063f2a04d158ec1b275a925dfbae74b124708cde prevents building > >>>>> with such versions. > >>>>> > >>>>> Signed-off-by: Stanislav Kholmanskikh > >>>>> --- > >>>>> conf/Makefile.common | 8 ++++++++ > >>>>> configure.ac | 10 ++++++++++ > >>>>> 2 files changed, 18 insertions(+), 0 deletions(-) > >>>>> > >>>>> diff --git a/conf/Makefile.common b/conf/Makefile.common > >>>>> index e4c301f..5bda66f 100644 > >>>>> --- a/conf/Makefile.common > >>>>> +++ b/conf/Makefile.common > >>>>> @@ -8,11 +8,19 @@ unexport LC_ALL > >>>>> # Platform specific options > >>>>> if COND_sparc64_ieee1275 > >>>>> CFLAGS_PLATFORM +=3D -mno-app-regs > >>>>> +if COND_LD_SUPPORTS_NO_RELAX > >>>>> LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -Wl,--no-relax > >>>>> +else > >>>>> + LDFLAGS_PLATFORM =3D -Wl,-melf64_sparc -mno-relax > >>>>> +endif > >>>> > >>>> TBO I think commit should simply be reverted. "Uniformity" is rather > >>>> poor excuse for breaking existing systems. > >>>> > >>> This commit is needed for clang to compile for sparc64. Given that > >>> sparc64 clang still doesn't really work I'm ok with reverting, at lea= st > >>> for now. > >> > >> But, it this case, maybe it would be better to consider=20 > >> reviewing/applying this patch? Just to not return to this issue after= =20 > >> some time? > >> > >> Andrey, Vladimir, what do you think? > >> > >=20 > > Yes, commit message was pretty confusing. This leaves the question, > > whether combination of clang and binutils that do not support > > -Wl,--no-relax exists though :) Otherwise I agree, we should use this > > patch. > >=20 > I think we could try to push for clang to have -mno-relax. They're > usually pretty responsive and we'll probably need few fixes for few > other clang problems anyway. For now I just reverted it. Did you push it? --Sig_/5CRPo4Ks8ElzQg=Dh9PZ=yq Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEARECAAYFAlQfD+YACgkQR6LMutpd94xKVgCfTB9HQWgYv4PwNwbODhASVaZA izkAnROD5uL6NmqD9rSK5bNHs4t5RUgT =2HrT -----END PGP SIGNATURE----- --Sig_/5CRPo4Ks8ElzQg=Dh9PZ=yq--