From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XlL3a-0001MC-8T for mharc-grub-devel@gnu.org; Mon, 03 Nov 2014 12:04:42 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34887) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlL3T-0001JA-7b for grub-devel@gnu.org; Mon, 03 Nov 2014 12:04:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XlL3N-0001tO-Hi for grub-devel@gnu.org; Mon, 03 Nov 2014 12:04:35 -0500 Received: from mail-lb0-x230.google.com ([2a00:1450:4010:c04::230]:34786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XlL3N-0001tA-75 for grub-devel@gnu.org; Mon, 03 Nov 2014 12:04:29 -0500 Received: by mail-lb0-f176.google.com with SMTP id z11so7491931lbi.7 for ; Mon, 03 Nov 2014 09:04:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=yB4wYB6sOFHElJM48+u4Pm4fSEcyPdVLD+rGXEEVo1o=; b=Kimn5AE/vVeanoNRVvrvOCbgkUnJ7Zy4BHUKas/uNOhtFsWj3kzhF8hiDi58ztQFGN 2o65ytis6vxp5MYQwXkQA5BozbDI3C3b8OjIWK9NfcwWYI226p66gRcXMV2LzrsF7A5z JoDxUs+xYACG5znvIY6v7nqXOIv+z83Ong4loEwRePNRgXjEZNYufJvGasUZFPs+0j4M NlOPuyfqeVgBG6uvmE/ozJRmenpjG5DxLbokks+KZyYCXWjwV+9pm4l8yjEAkE9R0hbr r8xEjrT7NNuWKtvuLuZvLesgrxdQozPiT3YMAv9HG/Fs67u7pw0ozOxKzV571iVA1/Nh 0/oQ== X-Received: by 10.152.43.77 with SMTP id u13mr5189478lal.98.1415034267662; Mon, 03 Nov 2014 09:04:27 -0800 (PST) Received: from opensuse.site (ppp91-76-139-38.pppoe.mtu-net.ru. [91.76.139.38]) by mx.google.com with ESMTPSA id m3sm107978laa.10.2014.11.03.09.04.26 for (version=SSLv3 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 03 Nov 2014 09:04:26 -0800 (PST) Date: Mon, 3 Nov 2014 20:04:25 +0300 From: Andrei Borzenkov To: Michael Chang Subject: Re: [PATCH] icmp6 fix no respond to neighbor solicit message Message-ID: <20141103200425.0a4f5e2f@opensuse.site> In-Reply-To: <1415003265-13848-1-git-send-email-mchang@suse.com> References: <1415003265-13848-1-git-send-email-mchang@suse.com> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::230 Cc: grub-devel@gnu.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Nov 2014 17:04:41 -0000 =D0=92 Mon, 3 Nov 2014 16:27:45 +0800 Michael Chang =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > The structure size used in grub_netbuff_pull to get the pointer to > option header is apparently wrong, which leads to subsequent range check > failed and therefore not responding to any neighbor solicit message in my > testing. pushed > --- > grub-core/net/icmp6.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/grub-core/net/icmp6.c b/grub-core/net/icmp6.c > index bbc9020..796d549 100644 > --- a/grub-core/net/icmp6.c > +++ b/grub-core/net/icmp6.c > @@ -205,7 +205,7 @@ grub_net_recv_icmp6_packet (struct grub_net_buff *nb, > if (ttl !=3D 0xff) > break; > nbh =3D (struct neighbour_solicit *) nb->data; > - err =3D grub_netbuff_pull (nb, sizeof (struct router_adv)); > + err =3D grub_netbuff_pull (nb, sizeof (*nbh)); > if (err) > { > grub_netbuff_free (nb);