grub-devel.gnu.org archive mirror
 help / color / mirror / Atom feed
From: Felix Janda <felix.janda@posteo.de>
To: Andrei Borzenkov <arvidjaar@gmail.com>
Cc: grub-devel@gnu.org, daggs <daggs@gmx.com>
Subject: Re: grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc
Date: Thu, 27 Nov 2014 23:27:05 +0100	[thread overview]
Message-ID: <20141127222704.GA6207@euler> (raw)
In-Reply-To: <20141127173456.598c173a@opensuse.site>

Andrei Borzenkov wrote:
> В Fri, 21 Nov 2014 21:00:41 +0100
> Felix Janda <felix.janda@posteo.de> пишет:
> 
> > Hello,
> > 
> > the file grub-core/osdep/unix/hostdisk.c has special code for glibc<2.1,
> > which gets also pulled in for other libcs (such as musl libc) and makes
> > compilation fail for them because the code uses glibc internals. The
> > easiest way to fix is just to remove the code as the below patch does.
> > 
> 
> Could you replace glibc version check with configure test for llseek?
> This should cover your case as well.

There is no llseek.

Testing for lseek will likely also succeed for old glibc. I think that
one rather needs to check whether its prototype is correct.

I don't think that the code behind !defined(__GLIBC__) ... is useful
for anything other than glibc<2.1. It seems to use old glibc internals.
(Notice that glibc-2.1 is from 1999.) If the code should be kept in,
it should IMO be conditional on 

((__GLIBC__ < 2) || ((__GLIBC__ == 2) && (__GLIBC_MINOR__ < 1)))


Felix


  reply	other threads:[~2014-11-27 22:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21 20:00 grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc Felix Janda
2014-11-22  8:59 ` Felix Janda
2014-11-27 14:34 ` Andrei Borzenkov
2014-11-27 22:27   ` Felix Janda [this message]
2014-11-28 19:18 ` Vladimir 'φ-coder/phcoder' Serbinenko
2014-12-04 22:21   ` Felix Janda
2014-12-05 11:52     ` Andrei Borzenkov
2014-12-05 17:50       ` Felix Janda
2014-12-07 16:24     ` Vladimir 'φ-coder/phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141127222704.GA6207@euler \
    --to=felix.janda@posteo.de \
    --cc=arvidjaar@gmail.com \
    --cc=daggs@gmx.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).