From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from list by lists.gnu.org with archive (Exim 4.71)
	id 1Xwemh-0007mU-J1
	for mharc-grub-devel@gnu.org; Thu, 04 Dec 2014 17:22:03 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52529)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <felix.janda@posteo.de>) id 1XwemY-0007lH-QD
	for grub-devel@gnu.org; Thu, 04 Dec 2014 17:22:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <felix.janda@posteo.de>) id 1XwemR-0003nK-AU
	for grub-devel@gnu.org; Thu, 04 Dec 2014 17:21:54 -0500
Received: from mx02.posteo.de ([89.146.194.165]:56221)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <felix.janda@posteo.de>) id 1XwemR-0003mq-52
	for grub-devel@gnu.org; Thu, 04 Dec 2014 17:21:47 -0500
Received: from dovecot04.posteo.de (unknown [185.67.36.27])
	by mx02.posteo.de (Postfix) with ESMTPS id 0C3DC25A3DDB
	for <grub-devel@gnu.org>; Thu,  4 Dec 2014 23:21:44 +0100 (CET)
Received: from mail.posteo.de (localhost [127.0.0.1])
	by dovecot04.posteo.de (Postfix) with ESMTPSA id 3jts3D0ZX1zFpWN
	for <grub-devel@gnu.org>; Thu,  4 Dec 2014 23:21:43 +0100 (CET)
Date: Thu, 4 Dec 2014 23:21:09 +0100
From: Felix Janda <felix.janda@posteo.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: grub-core/osdep/unix/hostdisk.c: remove support for ancient glibc
Message-ID: <20141204222109.GA30539@euler>
References: <20141121200040.GA4858@euler>
 <5478CA6D.9020904@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5478CA6D.9020904@gmail.com>
User-Agent: Mutt/1.5.22 (2013-10-16)
Content-Transfer-Encoding: quoted-printable
X-detected-operating-system: by eggs.gnu.org: Genre and OS details not
	recognized.
X-Received-From: 89.146.194.165
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: The development of GNU GRUB <grub-devel@gnu.org>
List-Id: The development of GNU GRUB <grub-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Dec 2014 22:22:02 -0000

On 28.11.2014, Vladimir '=CF=86-coder/phcoder' Serbinenko wrote:
> On 21.11.2014 22:00, Felix Janda wrote:
> > Hello,
> >=20
> > the file grub-core/osdep/unix/hostdisk.c has special code for glibc<2=
.1,
> > which gets also pulled in for other libcs (such as musl libc) and mak=
es
> > compilation fail for them because the code uses glibc internals. The
> > easiest way to fix is just to remove the code as the below patch does=
.
> >=20
> Don't assume that nobody will try to compile with ancient glibc. If you
> want to raise the supported version for glibc you need to add a
> configure check for presence of long offsets to configure and fail it i=
f
> it's not available. It should also be documented in INSTALL.

Before messing around with configure.ac, I'd like know whether a patch
(correctly) implementing what you suggest would be accepted.

Another solution I would be happy with, is to change the conditions

# if !defined(__GLIBC__) || \
        ((__GLIBC__ < 2) || ((__GLIBC__ =3D=3D 2) && (__GLIBC_MINOR__ < 1=
)))

to

# ((__GLIBC__ < 2) || ((__GLIBC__ =3D=3D 2) && (__GLIBC_MINOR__ < 1)))

Felix